pnpm patchedDependencies bug with excluded patch files

[ChromeQ]

I have found that the pnpm patchedDependencies from other workspaces do not work when firebase tries to install the functions.

Here is the relevant part of my pnpm-workspace.yml with patchedDependencies: (note they are all in other dirs, not my firebase functions dir)

Here is the isolate output with debug logs:

You can see it detects the 5 patch files but correctly excludes them as they do not target the "functions" dir.
Confirming they are not in the target dir:

However, the pnpm-workspace.yml file is copied into the isolate folder with all patches defined.

But when firebase tries to install deps during deploy then it fails with the following:

So it can't find the patches and rightly errors. It can be repeated by simply deleting a patch file and trying to run pnpm i even in your main dir, not isolate dir.
The solution is to either filter the excluded patches from the patchedDependencies list in the copied pnpm-workspace.yml or simply copy them over always so they can resolve.

[ChromeQ]

Another follow up, I manually copied the patches into the isolate folder and recreated the structure:

There were no more "ENOENT: no such file or directory" but instead this:

happy-hour-hunter/functions/isolate on  tech/0eJvMPil-pnpm-firebase-deploy-2 [$!] via  v24.13.0 
❯ pnpm i
 ERR_PNPM_UNUSED_PATCH  The following patches were not used: react-native-dropdown-picker, react-native-map-clustering, wrangler, react-native-google-places-autocomplete, @rneui/base

Either remove them from "patchedDependencies" or update them to match packages in your dependencies.
Progress: resolved 345, reused 345, downloaded 0, added 0

I think this means the only viable solution is to remove the excluded patches from the pnpm-workspace.yml copied to isolate folder.

---

Edit:
Confirmed, manually deleted the patch files and the patchedDependencies block in the isolate/pnpm-workspace.yml and then pnpm i completed successfully.

I will see if I can find time to submit a PR

[0x80]

@ChromeQ Thanks for reporting! I already started a PR right after you reported it, but I forgot to wrap it up yesterday. That's why I didn't notice yours and we now have two. I will compare my (Claude) solution to yours...

[0x80]

I've now landed on a combination of the two. See motivation below.

Comparison summary:

Same core fix (their commit 1 ≈ mine)

• Read pnpm-workspace.yaml, rewrite patchedDependencies from copiedPatches, delete the field if empty, write back.
• Their description even calls out the same downside I have: read-modify-write loses comments and key order in the yaml even when nothing actually changed.

One genuinely good idea worth borrowing

• Their commit 2 preserves a verbatim fs.copyFileSync whenever no patches were excluded. That's a nicer outcome than mine for the common case where every workspace patch is reachable
  from the target — comments, ordering, and trailing whitespace stay intact.

One bug to avoid copying from them

• Commit 2 also changes copy-patches.ts to iterate patchedDependencies instead of filteredPatches, which means every patch file gets copied to disk regardless of relevance. That
  defeats the existing exclusion behavior added in Bug: Upstream/transitive patched dependencies are omitted during isolation #167/Preserve patches for transitive dependencies via internal packages #177. The "did anything get excluded" signal can be derived without touching copy-patches.ts: just compare the source yaml's
  patchedDependencies keys with copiedPatches keys after reading it.

Recommendation

• Adopt the spirit of their commit 1 — same as mine, no change needed.
• Adopt the spirit of their commit 2 (preserve verbatim copy when there's nothing to filter), but implement it locally in the new helper without changing copy-patches.ts's return
  shape or its filtering loop.
• Skip their copy-patches.ts refactor.

[ChromeQ]

No worries, it was a bit of a blocker for me and it was the last part of my yarn > pnpm migration and didn't want to start something new until this was finalise so I decided to do it myself and submit.

I also used Opus-4.7 for most of commit 1, commit 2 was all me (hence the bug 😅) as I thought it would be nice to preserve the direct copy.

I'll give a review of the changes (even though it is merged already!) and if released I will test it out and get back to you, if all good then I'll close this issue. Thanks @0x80

---

Edit just noticed it is not merged, will give some 👀 now

[0x80]

@ChromeQ the issue was auto closed because it was linked to the PR. I trusted the solution enough to just publish it. I've also just published an update to firebase-tools-with-isolate that includes the new version in case you use that.

[ChromeQ]

Thanks, I just upgraded to the latest version but didn't deploy yet to test fully, but I am confident it will.
I'm not using firebase tools with isolate as I have another workaround for local dev