Issue when binary data is contains delimeter in case of websocket

[narad-muni]

According to EngineIO Websocket Spec, each packet is sent in its seperate websocket frame, and in case of polling it is encoded in base64.
But here packet.rs iresepective of what the mode is, the code is splitting the packet by delimeter. This causes incomplete or invalid packets in case of binary message in websocket mode.

[narad-muni]

I would like to pick this up if possible.

[1c3t3a]

Ohh interesting! Feel free to, I am happy to review :)

[narad-muni]

Can you confirm if this is actually and issue ?
Also would like to get and entrypoint to get started.

[1c3t3a]

So reiterating on this: I don't really think it is an issue because we operate above the transport (websocket, polling, etc) layer. So this code works on already transmitted bytes and parses them accordingly. With your issue request I kinda expected that you found a concrete issue where this is wrong (e.g. data containing websocket delimiters). If that's not the case, it's not an issue I guess.

[narad-muni]

From what I can understand, the flow is get bytes from here websocket_general.rs then the bytes are converted to payload(packets) by splitting in here socket.rs.
This call leads to the binary packet being split incorrectly if delimiter is present in raw binary as in websocket it isn't base 64 encoded.