From 88b97445aa228396e09c734eb6f6407a90635f8f Mon Sep 17 00:00:00 2001
From: Ahmed <ahmedfathyghazy@gmail.com>
Date: Sun, 29 Jul 2018 12:40:48 +0200
Subject: [PATCH 1/3] Add dagger2 support

---
 app/src/main/AndroidManifest.xml              |  1 +
 .../blink22/android/mvpandroid/BaseApp.java   | 31 +++++++
 .../android/mvpandroid/di/AppModule.java      | 27 ++++++
 .../mvpandroid/di/NetworkComponent.java       | 21 +++++
 .../android/mvpandroid/di/NetworkModule.java  | 88 +++++++++++++++++++
 .../mvpandroid/newTodo/NewTodoFragment.java   | 10 ++-
 .../mvpandroid/todos/TodosActivity.java       |  6 ++
 .../mvpandroid/todos/TodosFragment.java       | 17 ++--
 .../mvpandroid/todos/TodosPresenter.java      |  3 -
 9 files changed, 195 insertions(+), 9 deletions(-)
 create mode 100644 app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
 create mode 100644 app/src/main/java/com/blink22/android/mvpandroid/di/AppModule.java
 create mode 100644 app/src/main/java/com/blink22/android/mvpandroid/di/NetworkComponent.java
 create mode 100644 app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index c87e9f8..bb72880 100755
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -4,6 +4,7 @@
     <uses-permission android:name="android.permission.INTERNET" />
 
     <application
+        android:name=".BaseApp"
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java b/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
new file mode 100644
index 0000000..c22a6a1
--- /dev/null
+++ b/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
@@ -0,0 +1,31 @@
+package com.blink22.android.mvpandroid;
+
+import android.app.Application;
+
+import com.blink22.android.mvpandroid.di.AppModule;
+import com.blink22.android.mvpandroid.di.DaggerNetworkComponent;
+import com.blink22.android.mvpandroid.di.NetworkComponent;
+import com.blink22.android.mvpandroid.di.NetworkModule;
+
+/**
+ * Created by ahmedghazy on 7/29/18.
+ */
+
+public class BaseApp extends Application {
+    NetworkComponent mNetworkComponent;
+
+    @Override
+    public void onCreate() {
+        super.onCreate();
+
+        mNetworkComponent = DaggerNetworkComponent.builder()
+                .appModule(new AppModule(this))
+                .networkModule(new NetworkModule(BuildConfig.BASE_URL))
+                .build();
+
+    }
+
+    public NetworkComponent getNetworkComponent() {
+        return mNetworkComponent;
+    }
+}
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/di/AppModule.java b/app/src/main/java/com/blink22/android/mvpandroid/di/AppModule.java
new file mode 100644
index 0000000..f8bd99c
--- /dev/null
+++ b/app/src/main/java/com/blink22/android/mvpandroid/di/AppModule.java
@@ -0,0 +1,27 @@
+package com.blink22.android.mvpandroid.di;
+
+import android.app.Application;
+
+import javax.inject.Singleton;
+
+import dagger.Module;
+import dagger.Provides;
+
+/**
+ * Created by ahmedghazy on 7/29/18.
+ */
+
+@Module
+public class AppModule {
+    Application mApplication;
+
+    public AppModule(Application application) {
+        mApplication = application;
+    }
+
+    @Provides
+    @Singleton
+    public Application providesApplication() {
+        return mApplication;
+    }
+}
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkComponent.java b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkComponent.java
new file mode 100644
index 0000000..42e5e28
--- /dev/null
+++ b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkComponent.java
@@ -0,0 +1,21 @@
+package com.blink22.android.mvpandroid.di;
+
+import com.blink22.android.mvpandroid.newTodo.NewTodoActivity;
+import com.blink22.android.mvpandroid.newTodo.NewTodoFragment;
+import com.blink22.android.mvpandroid.todos.TodosActivity;
+import com.blink22.android.mvpandroid.todos.TodosFragment;
+
+import javax.inject.Singleton;
+
+import dagger.Component;
+
+/**
+ * Created by ahmedghazy on 7/29/18.
+ */
+
+@Singleton
+@Component(modules={AppModule.class, NetworkModule.class})
+public interface NetworkComponent {
+    void inject(TodosFragment todosFragment);
+    void inject(NewTodoFragment newTodoFragment);
+}
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
new file mode 100644
index 0000000..0ea4771
--- /dev/null
+++ b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
@@ -0,0 +1,88 @@
+package com.blink22.android.mvpandroid.di;
+
+import android.app.Application;
+
+import com.blink22.android.mvpandroid.apiInterfaces.TodosService;
+import com.blink22.android.mvpandroid.network.TodosSubscriber;
+import com.google.gson.Gson;
+
+import java.io.File;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import dagger.Module;
+import dagger.Provides;
+import okhttp3.Cache;
+import okhttp3.OkHttpClient;
+import retrofit2.CallAdapter;
+import retrofit2.Retrofit;
+import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory;
+import retrofit2.converter.gson.GsonConverterFactory;
+
+/**
+ * Created by ahmedghazy on 7/29/18.
+ */
+
+@Module
+public class NetworkModule {
+    String mUrl;
+
+    public NetworkModule(String url) {
+        this.mUrl = url;
+    }
+
+    @Provides
+    @Singleton
+    Cache provideOkHttpCache(Application application) {
+        int cacheSize = 5 * 1024 * 1024;
+        Cache cache = new Cache(application.getCacheDir(), cacheSize);
+        return cache;
+    }
+
+    @Provides
+    @Singleton
+    @Named("cached")
+    OkHttpClient provideOkHttpClient(Cache cache) {
+        OkHttpClient okHttpClient = new OkHttpClient.Builder().cache(cache).build();
+        return okHttpClient;
+    }
+
+    @Provides
+    @Singleton
+    @Named("non_cached")
+    OkHttpClient provideOkHttpClientNonCached() {
+        OkHttpClient okHttpClient = new OkHttpClient();
+        return okHttpClient;
+    }
+
+    @Provides
+    @Singleton
+    @Named("rxjava2_call_adapter")
+    CallAdapter.Factory provideCallAdapterFactory() {
+        return RxJava2CallAdapterFactory.create();
+    }
+
+    @Provides
+    @Singleton
+    Retrofit provideRetrofit(@Named("cached") OkHttpClient okHttpClient, @Named("rxjava2_call_adapter") CallAdapter.Factory rxJava2CallAdapterFactory) {
+        return new Retrofit.Builder()
+                .addConverterFactory(GsonConverterFactory.create())
+                .addCallAdapterFactory(rxJava2CallAdapterFactory)
+                .baseUrl(mUrl)
+                .client(okHttpClient)
+                .build();
+    }
+
+    @Provides
+    @Singleton
+    TodosService provideTodosService(Retrofit retrofit) {
+        return retrofit.create(TodosService.class);
+    }
+
+    @Provides
+    @Singleton
+    TodosSubscriber provideTodosSubscriber(TodosService todosService) {
+        return new TodosSubscriber(todosService);
+    }
+}
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
index 8ed3caa..9b11e7f 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
@@ -11,10 +11,14 @@
 import android.widget.Button;
 import android.widget.TextView;
 
+import com.blink22.android.mvpandroid.BaseApp;
 import com.blink22.android.mvpandroid.R;
 import com.blink22.android.mvpandroid.network.NetworkManager;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 
+
+import javax.inject.Inject;
+
 import butterknife.BindView;
 import butterknife.ButterKnife;
 
@@ -33,6 +37,7 @@ public class NewTodoFragment extends Fragment implements NewTodoContract.View {
     @BindView(R.id.new_todo_submit)
     Button mSubmit;
     NewTodoContract.Presenter mPresenter;
+    @Inject TodosSubscriber mTodosSubscriber;
 
     public static NewTodoFragment newInstance() {
         
@@ -46,7 +51,10 @@ public static NewTodoFragment newInstance() {
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        setPresenter(NewTodoPresenter.getInstance(new TodosSubscriber(NetworkManager.getInstance().getTodosService()), this));
+
+        ((BaseApp) getActivity().getApplication()).getNetworkComponent().inject(this);
+
+        setPresenter(NewTodoPresenter.getInstance(mTodosSubscriber, this));
         getLifecycle().addObserver(mPresenter);
     }
 
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
index a1711b1..ddb461b 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
@@ -11,6 +11,7 @@
 import android.widget.ProgressBar;
 import android.widget.Toast;
 
+import com.blink22.android.mvpandroid.BaseApp;
 import com.blink22.android.mvpandroid.activities.BaseActivity;
 import com.blink22.android.mvpandroid.adapters.TodosAdapter;
 import com.blink22.android.mvpandroid.models.Todo;
@@ -34,4 +35,9 @@ public class TodosActivity extends BaseActivity{
     protected Fragment createFragment() {
         return TodosFragment.newInstance();
     }
+
+    @Override
+    public void onCreate(@Nullable Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+    }
 }
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
index 8140f43..5f65b16 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
@@ -14,6 +14,7 @@
 import android.widget.ProgressBar;
 import android.widget.Toast;
 
+import com.blink22.android.mvpandroid.BaseApp;
 import com.blink22.android.mvpandroid.activities.BaseActivity;
 import com.blink22.android.mvpandroid.adapters.TodosAdapter;
 import com.blink22.android.mvpandroid.models.Todo;
@@ -24,6 +25,8 @@
 import com.blink22.android.mvpandroid.network.NetworkManager;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 
+import javax.inject.Inject;
+
 import butterknife.BindView;
 import butterknife.ButterKnife;
 
@@ -32,6 +35,11 @@
  */
 
 public class TodosFragment extends Fragment implements TodosContract.View {
+    @BindView(R.id.todos_list) RecyclerView mTodos;
+    @BindView(R.id.todos_progress) ProgressBar mProgressBar;
+    TodosContract.Presenter mTodosPresenter;
+    @Inject TodosSubscriber mTodosSubscriber;
+
 
     public static TodosFragment newInstance() {
 
@@ -44,14 +52,13 @@ public static TodosFragment newInstance() {
 
     private static final String TAG = TodosActivity.class.getSimpleName();
 
-    @BindView(R.id.todos_list) RecyclerView mTodos;
-    @BindView(R.id.todos_progress) ProgressBar mProgressBar;
-    TodosContract.Presenter mTodosPresenter;
-
     @Override
     public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        setPresenter(TodosPresenter.getInstance(new TodosSubscriber(NetworkManager.getInstance().getTodosService()), this));
+
+        ((BaseApp) getActivity().getApplication()).getNetworkComponent().inject(this);
+
+        setPresenter(TodosPresenter.getInstance(mTodosSubscriber, this));
         getLifecycle().addObserver(mTodosPresenter);
     }
 
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
index 1749963..be35ba2 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
@@ -7,13 +7,10 @@
 import com.blink22.android.mvpandroid.models.Todo;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 
-import java.lang.reflect.Array;
 import java.util.ArrayList;
 
 import io.reactivex.disposables.CompositeDisposable;
 import io.reactivex.observers.DisposableObserver;
-import rx.Subscription;
-import rx.subscriptions.CompositeSubscription;
 
 /**
  * Created by ahmedghazy on 7/25/18.

From 14e166253389bbbb2b0204cdd07ade69fa97cc91 Mon Sep 17 00:00:00 2001
From: Ahmed <ahmedfathyghazy@gmail.com>
Date: Sun, 29 Jul 2018 14:31:10 +0200
Subject: [PATCH 2/3] Add url dependency injection

---
 .../com/blink22/android/mvpandroid/BaseApp.java   |  2 +-
 .../android/mvpandroid/di/NetworkModule.java      | 15 +++++++++------
 db.json                                           |  8 +++++++-
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java b/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
index c22a6a1..a016d87 100644
--- a/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/BaseApp.java
@@ -20,7 +20,7 @@ public void onCreate() {
 
         mNetworkComponent = DaggerNetworkComponent.builder()
                 .appModule(new AppModule(this))
-                .networkModule(new NetworkModule(BuildConfig.BASE_URL))
+                .networkModule(new NetworkModule())
                 .build();
 
     }
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
index 0ea4771..d35767d 100644
--- a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
@@ -2,6 +2,7 @@
 
 import android.app.Application;
 
+import com.blink22.android.mvpandroid.BuildConfig;
 import com.blink22.android.mvpandroid.apiInterfaces.TodosService;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 import com.google.gson.Gson;
@@ -26,10 +27,10 @@
 
 @Module
 public class NetworkModule {
-    String mUrl;
-
-    public NetworkModule(String url) {
-        this.mUrl = url;
+    @Provides
+    @Named("api_url")
+    String provideApiLink() {
+        return BuildConfig.BASE_URL;
     }
 
     @Provides
@@ -65,11 +66,13 @@ CallAdapter.Factory provideCallAdapterFactory() {
 
     @Provides
     @Singleton
-    Retrofit provideRetrofit(@Named("cached") OkHttpClient okHttpClient, @Named("rxjava2_call_adapter") CallAdapter.Factory rxJava2CallAdapterFactory) {
+    Retrofit provideRetrofit(@Named("cached") OkHttpClient okHttpClient,
+                             @Named("rxjava2_call_adapter") CallAdapter.Factory rxJava2CallAdapterFactory,
+                             @Named("api_url") String url) {
         return new Retrofit.Builder()
                 .addConverterFactory(GsonConverterFactory.create())
                 .addCallAdapterFactory(rxJava2CallAdapterFactory)
-                .baseUrl(mUrl)
+                .baseUrl(url)
                 .client(okHttpClient)
                 .build();
     }
diff --git a/db.json b/db.json
index e175372..d2a0ca5 100644
--- a/db.json
+++ b/db.json
@@ -2,7 +2,7 @@
   "todos": [
     {
       "details": "Go to the market to buy carrots",
-      "done": false,
+      "done": true,
       "id": 1,
       "title": "Buy grocery"
     },
@@ -149,6 +149,12 @@
       "done": true,
       "id": 25,
       "title": "dsa Title"
+    },
+    {
+      "details": "Ghazy Description",
+      "done": false,
+      "id": 26,
+      "title": "Title Ghazy"
     }
   ]
 }
\ No newline at end of file

From e144d3f8ba1cbf7801589c3c4feb4a0184d51f8d Mon Sep 17 00:00:00 2001
From: Ahmed <ahmedfathyghazy@gmail.com>
Date: Sun, 29 Jul 2018 14:51:40 +0200
Subject: [PATCH 3/3] Refactor removing whitespaces renaming packages

---
 .../android/mvpandroid/{activities => }/BaseActivity.java    | 2 +-
 .../blink22/android/mvpandroid/adapters/TodosAdapter.java    | 1 -
 .../{apiInterfaces => apiinterfaces}/TodosService.java       | 3 +--
 .../com/blink22/android/mvpandroid/di/NetworkModule.java     | 2 +-
 .../android/mvpandroid/models/NavigationItemEnum.java        | 3 ---
 .../java/com/blink22/android/mvpandroid/models/Todo.java     | 1 -
 .../blink22/android/mvpandroid/network/NetworkManager.java   | 5 +----
 .../blink22/android/mvpandroid/network/TodosSubscriber.java  | 3 +--
 .../blink22/android/mvpandroid/newTodo/NewTodoActivity.java  | 2 +-
 .../blink22/android/mvpandroid/newTodo/NewTodoFragment.java  | 1 -
 .../com/blink22/android/mvpandroid/todos/TodosActivity.java  | 2 +-
 .../com/blink22/android/mvpandroid/todos/TodosFragment.java  | 3 +--
 .../com/blink22/android/mvpandroid/todos/TodosPresenter.java | 2 --
 13 files changed, 8 insertions(+), 22 deletions(-)
 rename app/src/main/java/com/blink22/android/mvpandroid/{activities => }/BaseActivity.java (97%)
 mode change 100755 => 100644
 rename app/src/main/java/com/blink22/android/mvpandroid/{apiInterfaces => apiinterfaces}/TodosService.java (91%)
 mode change 100755 => 100644

diff --git a/app/src/main/java/com/blink22/android/mvpandroid/activities/BaseActivity.java b/app/src/main/java/com/blink22/android/mvpandroid/BaseActivity.java
old mode 100755
new mode 100644
similarity index 97%
rename from app/src/main/java/com/blink22/android/mvpandroid/activities/BaseActivity.java
rename to app/src/main/java/com/blink22/android/mvpandroid/BaseActivity.java
index 357f919..5501ec7
--- a/app/src/main/java/com/blink22/android/mvpandroid/activities/BaseActivity.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/BaseActivity.java
@@ -1,4 +1,4 @@
-package com.blink22.android.mvpandroid.activities;
+package com.blink22.android.mvpandroid;
 
 import android.content.Intent;
 import android.os.Bundle;
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/adapters/TodosAdapter.java b/app/src/main/java/com/blink22/android/mvpandroid/adapters/TodosAdapter.java
index effe736..37f38e1 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/adapters/TodosAdapter.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/adapters/TodosAdapter.java
@@ -29,7 +29,6 @@ public TodosAdapter(Context context, ArrayList<Todo> data, OnItemClickListener l
         mContext = context;
     }
 
-
     @Override
     public TodosVH onCreateViewHolder(ViewGroup parent, int viewType) {
         View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.item_todos, null);
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/apiInterfaces/TodosService.java b/app/src/main/java/com/blink22/android/mvpandroid/apiinterfaces/TodosService.java
old mode 100755
new mode 100644
similarity index 91%
rename from app/src/main/java/com/blink22/android/mvpandroid/apiInterfaces/TodosService.java
rename to app/src/main/java/com/blink22/android/mvpandroid/apiinterfaces/TodosService.java
index 88d18b9..f2ec1aa
--- a/app/src/main/java/com/blink22/android/mvpandroid/apiInterfaces/TodosService.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/apiinterfaces/TodosService.java
@@ -1,10 +1,9 @@
-package com.blink22.android.mvpandroid.apiInterfaces;
+package com.blink22.android.mvpandroid.apiinterfaces;
 
 import com.blink22.android.mvpandroid.models.Todo;
 
 import java.util.ArrayList;
 
-
 import io.reactivex.Observable;
 import retrofit2.http.Body;
 import retrofit2.http.GET;
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
index d35767d..9596d74 100644
--- a/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/di/NetworkModule.java
@@ -3,7 +3,7 @@
 import android.app.Application;
 
 import com.blink22.android.mvpandroid.BuildConfig;
-import com.blink22.android.mvpandroid.apiInterfaces.TodosService;
+import com.blink22.android.mvpandroid.apiinterfaces.TodosService;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 import com.google.gson.Gson;
 
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/models/NavigationItemEnum.java b/app/src/main/java/com/blink22/android/mvpandroid/models/NavigationItemEnum.java
index f0fa0dc..ace0794 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/models/NavigationItemEnum.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/models/NavigationItemEnum.java
@@ -12,7 +12,6 @@ public enum NavigationItemEnum {
     HOME(R.string.list_todos, android.R.drawable.ic_dialog_info, TodosActivity.class, 0),
     ADD_NEW_NOTE(R.string.add_new_todo, android.R.drawable.ic_input_add, NewTodoActivity.class, 1);
 
-
     private int labelResourceId;
     private int iconResourceId;
     private Class classToLaunch;
@@ -41,5 +40,3 @@ public int getId() {
         return id;
     }
 }
-
-
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/models/Todo.java b/app/src/main/java/com/blink22/android/mvpandroid/models/Todo.java
index 5f8d315..401773f 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/models/Todo.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/models/Todo.java
@@ -10,7 +10,6 @@
 
 public class Todo{
 
-
     @SerializedName("id")
     private int id;
 
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/network/NetworkManager.java b/app/src/main/java/com/blink22/android/mvpandroid/network/NetworkManager.java
index 3cb5c01..8f4aac0 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/network/NetworkManager.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/network/NetworkManager.java
@@ -1,7 +1,7 @@
 package com.blink22.android.mvpandroid.network;
 
 import com.blink22.android.mvpandroid.BuildConfig;
-import com.blink22.android.mvpandroid.apiInterfaces.TodosService;
+import com.blink22.android.mvpandroid.apiinterfaces.TodosService;
 
 import java.io.IOException;
 
@@ -39,8 +39,6 @@ public static NetworkManager getInstance() {
 
     public TodosService getTodosService() {
         if (mTodosService == null) {
-
-
             mTodosService = new Retrofit
                     .Builder()
                     .baseUrl(BuildConfig.BASE_URL)
@@ -50,7 +48,6 @@ public TodosService getTodosService() {
                     .build()
                     .create(TodosService.class);
         }
-
         return mTodosService;
     }
 }
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/network/TodosSubscriber.java b/app/src/main/java/com/blink22/android/mvpandroid/network/TodosSubscriber.java
index 8cbf63d..d90da3e 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/network/TodosSubscriber.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/network/TodosSubscriber.java
@@ -1,9 +1,8 @@
 package com.blink22.android.mvpandroid.network;
 
-import com.blink22.android.mvpandroid.apiInterfaces.TodosService;
+import com.blink22.android.mvpandroid.apiinterfaces.TodosService;
 import com.blink22.android.mvpandroid.models.Todo;
 
-
 import java.util.ArrayList;
 
 import io.reactivex.Observable;
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoActivity.java b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoActivity.java
index 1b29630..4f357d9 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoActivity.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoActivity.java
@@ -2,7 +2,7 @@
 
 import android.support.v4.app.Fragment;
 
-import com.blink22.android.mvpandroid.activities.BaseActivity;
+import com.blink22.android.mvpandroid.BaseActivity;
 
 /**
  * Created by ahmedghazy on 7/26/18.
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
index 9b11e7f..99c6e56 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/newTodo/NewTodoFragment.java
@@ -16,7 +16,6 @@
 import com.blink22.android.mvpandroid.network.NetworkManager;
 import com.blink22.android.mvpandroid.network.TodosSubscriber;
 
-
 import javax.inject.Inject;
 
 import butterknife.BindView;
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
index ddb461b..a7da693 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosActivity.java
@@ -12,7 +12,7 @@
 import android.widget.Toast;
 
 import com.blink22.android.mvpandroid.BaseApp;
-import com.blink22.android.mvpandroid.activities.BaseActivity;
+import com.blink22.android.mvpandroid.BaseActivity;
 import com.blink22.android.mvpandroid.adapters.TodosAdapter;
 import com.blink22.android.mvpandroid.models.Todo;
 
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
index 5f65b16..7cc1832 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosFragment.java
@@ -15,7 +15,7 @@
 import android.widget.Toast;
 
 import com.blink22.android.mvpandroid.BaseApp;
-import com.blink22.android.mvpandroid.activities.BaseActivity;
+import com.blink22.android.mvpandroid.BaseActivity;
 import com.blink22.android.mvpandroid.adapters.TodosAdapter;
 import com.blink22.android.mvpandroid.models.Todo;
 
@@ -40,7 +40,6 @@ public class TodosFragment extends Fragment implements TodosContract.View {
     TodosContract.Presenter mTodosPresenter;
     @Inject TodosSubscriber mTodosSubscriber;
 
-
     public static TodosFragment newInstance() {
 
         Bundle args = new Bundle();
diff --git a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
index be35ba2..49e4b2e 100755
--- a/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
+++ b/app/src/main/java/com/blink22/android/mvpandroid/todos/TodosPresenter.java
@@ -51,8 +51,6 @@ public void getTodos() {
 
         mView.showWait();
 
-
-
         DisposableObserver<ArrayList<Todo>> disposableObserver = mTodosSubscriber.getTodos(new TodosSubscriber.Callback<ArrayList<Todo>>() {
             @Override
             public void onSuccess(ArrayList<Todo> todos) {