Skip to content

Commit 4c5773f

Browse files
committed
fix: Potential -Wdeprecated-literal-operator error in half.hpp inclusion
While compiling with clang v20+, it was emitting -Wdeprecated-literal-operator, and in future versions, this warning can be emitted as an error. Since we don't want to change the third party, we fixed this inside support/Half.h in this commit: afd78dd However, there is another direct inclusion of half/half.hpp inside tests/validation/CPP/LUT.cpp, and we could potentially hit this issue there again. Currently, we don't because of possible transitive inclusions including support/Half.h before we explicitly include half/half.hpp. But, relying on this is not stable and we'd like to use support/Half.h for every usage/inclusion of half.hpp members. You can easily reproduce an error by moving the include of half.hpp to the top, confirming our hypothesis that the error was suppressed only because it was suppressed through a transitive support/Half.h inclusion. Partially Resolves: COMPMID-7924 Change-Id: I204b14eebabe27b06eebf3024938e41748500785 Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>
1 parent 786e93a commit 4c5773f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tests/validation/CPP/LUT.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@
2222
* SOFTWARE.
2323
*/
2424
#include "src/core/helpers/LUTManager.h"
25+
#include "support/Half.h"
2526
#include "tests/framework/Asserts.h"
2627
#include "tests/framework/Macros.h"
2728
#include "tests/validation/Helpers.h"
2829
#include "tests/validation/Validation.h"
2930

30-
#include "include/half/half.hpp"
31-
3231
namespace arm_compute
3332
{
3433
namespace test

0 commit comments

Comments
 (0)