[sway/workspaces] Weird behavior when using quotes in workspace names

[Sayrus]

Hello,

I'm having some strange behavior when using workspaces with quotes in them. For instance:

# Simple example
set $example 10:"Cal"
bindsym $mod+0 workspace $example

When switching through Sway, the Waybar module shows "Cal". When clicking the module switches to Cal.

# Adding a leading space
set $example 10:" Cal"
bindsym $mod+0 workspace $example

When switching through Sway, the modules shows " Cal". However when clicking this on Waybar, it uses the workspace Cal "". Clicking this once more redirects to Cal`.

This matches the behavior of swaymsg workspace "10:"Cal"" (manually templated from https://github.com/Alexays/Waybar/blob/master/include/modules/sway/workspaces.hpp#L26).

If the module works like swaymsg, quotes in the namespace name should be escaped swaymsg workspace "10:\"Cal\"".

[Sayrus]

index 182bf631..08946509 100644
--- a/src/modules/sway/workspaces.cpp
+++ b/src/modules/sway/workspaces.cpp
@@ -369,11 +369,16 @@ Gtk::Button &Workspaces::addButton(const Json::Value &node) {
                                    node["name"].asString(), node["target_output"].asString(),
                                    "--no-auto-back-and-forth", node["name"].asString()));
         } else {
-          ipc_.sendCmd(IPC_COMMAND, fmt::format("workspace {} \"{}\"",
-                                                config_["disable-auto-back-and-forth"].asBool()
-                                                    ? "--no-auto-back-and-forth"
-                                                    : "",
-                                                node["name"].asString()));
+          std::string workspaceName = node["name"].asString();
+          std::string flag = config_["disable-auto-back-and-forth"].asBool()
+                                ? "--no-auto-back-and-forth"
+                                : "";
+          // Use number if available as it is guaranteed to not have special characters
+          if (node["num"].asInt() >= 0) {
+            ipc_.sendCmd(IPC_COMMAND, fmt::format("workspace {} number {}", flag, node["num"].asInt()));
+          } else {
+            ipc_.sendCmd(IPC_COMMAND, fmt::format("workspace {} {}", flag, workspaceName));
+          }
         }
       } catch (const std::exception &e) {
         spdlog::error("Workspaces: {}", e.what());

Removing the escapes in the template string actually resolves the issue (By matching the configuration file behavior). But then it breaks for workspaces containing keywords, such as my output workspace. (see 0a5da13)