fix: select default model after async models load

Author: Algorithm5838

src/lib/components/chat/Chat.svelte

@@ -1358,31 +1358,15 @@
 	// Web functions
 	//////////////////////////
 
-	const initNewChat = async () => {
-		console.log('initNewChat');
-		resetWebSearchConfirmation();
-
-		// Mark the outgoing chat as read before resetting; in-place created chats
-		// keep chatIdProp undefined, so navigateHandler never marks them read.
-		if ($chatId && !$temporaryChatEnabled) {
-			updateLastReadAt($chatId);
-		}
-
-		if ($user?.role !== 'admin' && $user?.permissions?.chat?.temporary_enforced) {
-			await temporaryChatEnabled.set(true);
-		}
-
-		if ($settings?.temporaryChatByDefault ?? false) {
-			if ($temporaryChatEnabled === false) {
-				await temporaryChatEnabled.set(true);
-			} else if ($temporaryChatEnabled === null) {
-				// if set to null set to false; refer to temp chat toggle click handler
-				await temporaryChatEnabled.set(false);
-			}
+	const applySelectedModels = async () => {
+		// $models loads asynchronously; resolving while empty blanks the selector and never recovers
+		if ($models.length === 0) {
+			return;
 		}
 
-		if ($user?.role !== 'admin' && !$user?.permissions?.chat?.temporary) {
-			await temporaryChatEnabled.set(false);
+		// keep a valid existing selection (e.g. user's manual choice)
+		if (selectedModels.some((modelId) => modelId && $models.some((m) => m.id === modelId))) {
+			return;
 		}
 
 		const availableModels = $models
@@ -1400,7 +1384,7 @@
 
 			if (urlModels.length === 1) {
 				if (!$models.find((m) => m.id === urlModels[0])) {
-					// Model not found; open model selector and prefill
+					// model not in list — open the selector prefilled with the requested id
 					const modelSelectorButton = document.getElementById('model-selector-0-button');
 					if (modelSelectorButton) {
 						modelSelectorButton.click();
@@ -1414,43 +1398,32 @@
 						}
 					}
 				} else {
-					// Model found; set it as selected
 					selectedModels = urlModels;
 				}
 			} else {
-				// Multiple models; set as selected
 				selectedModels = urlModels;
 			}
 
-			// Unavailable models filtering
 			selectedModels = selectedModels.filter((modelId) =>
 				$models.map((m) => m.id).includes(modelId)
 			);
 		} else {
+			// priority: folder → sticky session → user default → admin default
 			if ($selectedFolder?.data?.model_ids) {
-				// Set from folder model IDs
 				selectedModels = $selectedFolder?.data?.model_ids;
-			} else {
-				if (sessionStorage.selectedModels) {
-					// Set from session storage (temporary selection)
-					selectedModels = JSON.parse(sessionStorage.selectedModels);
-					sessionStorage.removeItem('selectedModels');
-				} else {
-					if ($settings?.models) {
-						// Set from user settings
-						selectedModels = $settings?.models;
-					} else if (defaultModels && defaultModels.length > 0) {
-						// Set from default models
-						selectedModels = defaultModels;
-					}
-				}
+			} else if (sessionStorage.selectedModels) {
+				selectedModels = JSON.parse(sessionStorage.selectedModels);
+				sessionStorage.removeItem('selectedModels');
+			} else if ($settings?.models) {
+				selectedModels = $settings?.models;
+			} else if (defaultModels && defaultModels.length > 0) {
+				selectedModels = defaultModels;
 			}
 
-			// Unavailable & hidden models filtering
 			selectedModels = selectedModels.filter((modelId) => availableModels.includes(modelId));
 		}
 
-		// Ensure at least one model is selected
+		// fall back to admin default, then the first available model
 		if (selectedModels.length === 0 || (selectedModels.length === 1 && selectedModels[0] === '')) {
 			if (availableModels.length > 0) {
 				if (defaultModels && defaultModels.length > 0) {
@@ -1461,14 +1434,53 @@
 					selectedModels.length === 0 ||
 					(selectedModels.length === 1 && selectedModels[0] === '')
 				) {
-					// Only fall back to first available model if default models didn't resolve
 					selectedModels = [availableModels?.at(0) ?? ''];
 				}
 			} else {
 				selectedModels = [''];
 			}
 		}
 
+		selectedModels = selectedModels.map((modelId) =>
+			$models.map((m) => m.id).includes(modelId) ? modelId : ''
+		);
+	};
+
+	// re-resolve once models load, covering the race where initNewChat() ran while $models was empty
+
+	$: if (chatIdProp === '' && $models.length > 0) {
+		applySelectedModels();
+	}
+
+	const initNewChat = async () => {
+		console.log('initNewChat');
+		resetWebSearchConfirmation();
+
+		// Mark the outgoing chat as read before resetting; in-place created chats
+		// keep chatIdProp undefined, so navigateHandler never marks them read.
+		if ($chatId && !$temporaryChatEnabled) {
+			updateLastReadAt($chatId);
+		}
+
+		if ($user?.role !== 'admin' && $user?.permissions?.chat?.temporary_enforced) {
+			await temporaryChatEnabled.set(true);
+		}
+
+		if ($settings?.temporaryChatByDefault ?? false) {
+			if ($temporaryChatEnabled === false) {
+				await temporaryChatEnabled.set(true);
+			} else if ($temporaryChatEnabled === null) {
+				// if set to null set to false; refer to temp chat toggle click handler
+				await temporaryChatEnabled.set(false);
+			}
+		}
+
+		if ($user?.role !== 'admin' && !$user?.permissions?.chat?.temporary) {
+			await temporaryChatEnabled.set(false);
+		}
+
+		await applySelectedModels();
+
 		if ($mobile) {
 			await showControls.set(false);
 		}