Revert "Improve simulation reproducibility with Geant4"

This reverts commit 6aeb032.

There appear to be problems with the randomness in Geant4 simulations.

Author: sawenzel

Common/Utils/include/CommonUtils/ConfigurationMacroHelper.h

@@ -69,21 +69,6 @@ T GetFromMacro(const std::string& file, const std::string& funcname, const std::
   return *ptr;
 }
 
-// just-in-time interpret some C++ function using ROOT and make result available to runtime
-// functiondecl: A string coding the function to call (example "bool foo(){ return true; }")
-// funcname: The name of the function to call (example "foo()")
-// type: Return type of function (example "bool")
-// unique: Some unique string identifier under which the result will be stored in gROOT global variable space
-template <typename T>
-T JITAndEvalFunction(const std::string& functiondecl, const std::string& funcname, const std::string& type, const std::string& unique)
-{
-  /** interpret and execute a function and retrieve pointer to the returned type **/
-  auto line = Form("%s; %s __%s__ = %s;", functiondecl.c_str(), type.c_str(), unique.c_str(), funcname.c_str());
-  gROOT->ProcessLine(line);
-  auto ptr = (T*)gROOT->GetGlobal(Form("__%s__", unique.c_str()))->GetAddress();
-  return *ptr;
-}
-
 } // namespace conf
 } // namespace o2
 

Detectors/Base/CMakeLists.txt

@@ -25,7 +25,6 @@ o2_add_library(DetectorsBase
                        src/TFIDInfoHelper.cxx
                        src/GRPGeomHelper.cxx
                        src/Stack.cxx
-                       src/VMCSeederService.cxx
                PUBLIC_LINK_LIBRARIES FairRoot::Base
                                      O2::CommonUtils
                                      O2::DetectorsCommonDataFormats

Detectors/Base/include/DetectorsBase/VMCSeederService.h

@@ -15,7 +15,6 @@
 
 #include "DetectorsBase/Stack.h"
 #include "DetectorsBase/Detector.h"
-#include <DetectorsBase/VMCSeederService.h>
 #include "DetectorsCommonDataFormats/DetID.h"
 #include "SimulationDataFormat/MCTrack.h"
 
@@ -363,7 +362,6 @@ TParticle* Stack::PopNextTrack(Int_t& iTrack)
         // LOG(info) << "SEEDING NEW TRACK USING HASH" << hash;
         // init seed per track
         gRandom->SetSeed(hash);
-        o2::base::VMCSeederService::instance().setSeed();
         // NOTE: THE BETTER PLACE WOULD BE IN PRETRACK HOOK BUT THIS DOES NOT SEEM TO WORK
         // WORKS ONLY WITH G3 SINCE G4 DOES NOT CALL THIS FUNCTION
       } // .trackSeed ?

Detectors/Base/src/Stack.cxx

@@ -23,7 +23,6 @@
 #include "TVirtualMC.h"
 #include "TMessage.h"
 #include <DetectorsBase/Stack.h>
-#include <DetectorsBase/VMCSeederService.h>
 #include <SimulationDataFormat/PrimaryChunk.h>
 #include <TRandom.h>
 #include <SimConfig/SimConfig.h>
@@ -258,7 +257,6 @@ class O2SimDevice final : public fair::mq::Device
                       << "part " << info.part << "/" << info.nparts;
             LOG(info) << workerStr() << " Setting seed for this sub-event to " << chunk->mSubEventInfo.seed;
             gRandom->SetSeed(chunk->mSubEventInfo.seed);
-            o2::base::VMCSeederService::instance().setSeed();
 
             // Process one event
             auto& conf = o2::conf::SimConfig::Instance();