[core] reset currentRunNumber in GO_ERROR instead of transition_startactivity

Author: Michal Tichák

core/environment/environment.go

@@ -602,6 +602,7 @@ func newEnvironment(userVars map[string]string, newId uid.ID) (env *Environment,
 							Debug("O2 End Completion time already set before after_GO_ERROR")
 					}
 					env.invalidateAutoStopTransition()
+					env.currentRunNumber = 0
 				}
 
 				errHooks = errors.Join(errHooks, env.handleHooksWithPositiveWeights(env.Workflow(), trigger))

core/environment/transition_startactivity.go

@@ -81,7 +81,6 @@ func (t StartActivityTransition) do(env *Environment) (err error) {
 	// Get a handle to the consolidated var stack of the root role of the env's workflow
 	if wf := env.Workflow(); wf != nil {
 		if cvs, cvsErr := wf.ConsolidatedVarStack(); cvsErr == nil {
-
 			// If bookkeeping is enabled and has fetched the LHC fill info, we can acquire it here
 			for _, key := range []string{
 				"fill_info_fill_number",
@@ -118,7 +117,6 @@ func (t StartActivityTransition) do(env *Environment) (err error) {
 	incomingEv := <-env.stateChangedCh
 	// If some tasks failed to transition
 	if tasksStateErrors := incomingEv.GetTasksStateChangedError(); tasksStateErrors != nil {
-		env.currentRunNumber = 0
 		return tasksStateErrors
 	}