Skip to content

Pgtrigger's makemigrations misses trigger changes when also patched by django-syzygy #223

Description

@oliverhaas

I'm using both django-pgtrigger and django-syzygy in my current main project. Both great packages 😄

django-syzygy is a package to make migrations safe during deployments.

Both packages patch MigrationAutodetector independently. syzygy imports Django's original class at module import time (before pgtrigger patches it), so pgtrigger's mixin never ends up in the MRO. Trigger operations are silently dropped. Workaround is not super complicated with syzygy's --dsiable-syzygy, but still annyoing and easy to miss.

I'm currently not sure whether it's better to adjust pgtrigger or django-syzygy, but I'll look into it, just wanted to get this out of the door.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions