Peer Review #68
Description
Code Review Outline – General Criteria & Notes
Code Review by Molly McCarthy for Nick Hanson
| Category | General Criteria | Notes / Comments |
|---|---|---|
| Project Scope & Functionality | - Uses all required technologies (JPA/Hibernate, authentication, APIs, database CRUD) - Meets MVP requirements - Database has multiple one-to-many relationships - Deployed and publicly accessible |
Site meets MVP; challenges have one drill item and many submissions; working prod vs. dev databases. |
| Experimentation & Innovation | - Demonstrates original solutions - Implements technologies beyond class coverage - Independently troubleshoots and researches |
This is such a cool idea and it was awesome to see it working. The use of markdown and runnable code on the website is great. The use of java.time.Duration and Instant is super interesting—I haven’t looked into that much, and now I want to watch a YouTube video on it! |
| Code Quality & Testing | - Readable and well organized - Proper documentation (Javadoc / comments) - Efficient without sacrificing readability - Good unit/integration test coverage - No System.out.println() or printStackTrace() |
Great testing quality with lots of coverage. Missing Javadoc on evaluator, external/model, and possibly other classes. Code is very readable—great work! |
| Project Planning & Milestones | - Demonstrates initiative and planning - Meets milestones - Effectively leverages resources |
Good plan overall, but could use reorganizing and updating. Many project details changed during the semester—README and plan need cleanup to match current project details. 🔗 Docs: • https://github.com/ArchILLtect/code-forge/blob/main/docs/project-plan.md • https://github.com/ArchILLtect/code-forge/blob/main/README.md (Tech stack might need updating!) |
| Revision & Feedback Incorporation | - Revisions based on feedback - Improvements are measurable |
Based on the timelog and commits, you’ve put a ton of work into this and iterated many times! |
| Complexity | - Overall project complexity is appropriate for scope - Combines multiple concepts effectively |
Good level of complexity. |
Closing thoughts: We talked last night about our plans for the next week and I think you had a great plan set in stone. You have the meat of your project working you just need redirect urls, clean repo and the notification fix! Exciting!
Checkpoint 1 – requirements (use if CP = 1)
- Problem statement, user stories, project plan, screen designs, and reflections are in GitHub
- MVP stories identified
- Repo link documented
Checkpoint 2 – requirements (use if CP = 2)
- Database designed and created (JPA config and tables present)
- At least one DAO with full CRUD implemented using Hibernate/JPA
- DAO unit/integration tests passing
- Log4J implemented (no System.out.println)
Checkpoint 3 – requirements (use if CP = 3)
- Deployed to AWS (link available)
- At least one JSP displays DB data
- Authentication implemented
Evidence (links, screenshots)
No response
References
No response
Demo plan (optional)
No response
Approval checklist
- All checkpoint requirements checked above
- Evidence attached
- Links added (docs, PRs, CI run)
- Ready for review