fix: improve type hints and simplify data filtering in Filters.php

Author: Ark4ne

src/Filters/Filters.php

@@ -2,10 +2,12 @@
 
 namespace Ark4ne\JsonApi\Filters;
 
+use Ark4ne\JsonApi\Support\Values;
 use Closure;
 use Illuminate\Contracts\Auth\Access\Gate;
 use Illuminate\Http\Request;
 use Illuminate\Http\Resources\MissingValue;
+use Illuminate\Http\Resources\PotentiallyMissing;
 use Illuminate\Support\Collection;
 
 /**
@@ -34,7 +36,7 @@ public function can(iterable|string $abilities, array $arguments = [], string $g
     /**
      * Add a custom filter rule
      *
-     * @param Closure $callback Callback that receives (Request $request, Model $model) and returns bool
+     * @param Closure(Request, Resource): bool $callback Callback that receives (Request $request, Model $model) and returns bool
      * @return static
      */
     public function when(Closure $callback): static
@@ -46,40 +48,43 @@ public function when(Closure $callback): static
     /**
      * Apply all filters to the given data
      *
-     * @param mixed $data
+     * @param Request $request
+     * @param null|PotentiallyMissing|Resource|iterable<array-key, Resource> $data
      * @return mixed
      */
     public function apply(Request $request, mixed $data): mixed
     {
-        if ($data instanceof MissingValue || $data === null) {
+        if ($data === null) {
+            return $data;
+        }
+        if (Values::isMissing($data)) {
             return $data;
         }
 
         // If it's a collection/array, filter each item
         if (is_iterable($data)) {
-            $filtered = [];
-            foreach ($data as $key => $item) {
-                if ($this->shouldInclude($request, $item)) {
-                    $filtered[$key] = $item;
-                }
-            }
-            
+            $filtered = (new Collection($data))
+                ->filter(fn($item) => $this->shouldInclude($request, $item));
+
             // Preserve the original collection type
             if ($data instanceof Collection) {
-                return new Collection($filtered);
+                return $filtered;
             }
 
-            return $filtered;
+            return $filtered->all();
         }
 
         // Single model - check if it should be included
-        return $this->shouldInclude($request, $data) ? $data : new MissingValue();
+        return $this->shouldInclude($request, $data)
+            ? $data
+            : new MissingValue();
     }
 
     /**
      * Check if a model should be included based on all filter rules
      *
-     * @param mixed $model
+     * @param Request $request
+     * @param Resource $model
      * @return bool
      */
     protected function shouldInclude(Request $request, mixed $model): bool