Fix properties with double quotes in it

Gummibeer · Gummibeer · commit 42704c27faaf · 2020-12-14T00:07:56.000+01:00
diff --git a/src/Property.php b/src/Property.php
@@ -27,6 +27,8 @@ public static function make(string $prefix, string $property, string $content)
 
     public function __toString(): string
     {
-        return "<meta property=\"{$this->prefix}:{$this->property}\" content=\"{$this->content}\">";
+        $content = str_replace('"', '&quot;', $this->content);
+
+        return "<meta property=\"{$this->prefix}:{$this->property}\" content=\"{$content}\">";
     }
 }
diff --git a/tests/GlobalTypesTest.php b/tests/GlobalTypesTest.php
@@ -20,6 +20,18 @@
     assertMatchesHtmlSnapshot((string) $og);
 })->group('global', 'website');
 
+it('can generate website tags with quotes', function () {
+    $og = Website::make('Title "\'&&amp; | Example')
+        ->url('http://www.example.com')
+        ->description('Description')
+        ->locale('en_US')
+        ->alternateLocale('en_GB')
+        ->siteName('Example')
+        ->image('http://www.example.com/image1.jpg');
+
+    assertMatchesHtmlSnapshot((string) $og);
+})->group('global', 'website');
+
 it('can generate website tags with stringable image', function () {
     $og = Website::make('Title | Example')
         ->url('http://www.example.com')
diff --git a/tests/__snapshots__/GlobalTypesTest__it_can_generate_website_tags_with_quotes__1.html b/tests/__snapshots__/GlobalTypesTest__it_can_generate_website_tags_with_quotes__1.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+<html><head>
+<meta property="og:type" content="website">
+<meta property="og:title" content="Title &quot;'&amp;&amp; | Example">
+<meta property="og:url" content="http://www.example.com">
+<meta property="og:description" content="Description">
+<meta property="og:locale" content="en_US">
+<meta property="og:locale:alternate" content="en_GB">
+<meta property="og:site_name" content="Example">
+<meta property="og:image" content="http://www.example.com/image1.jpg">
+</head></html>

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ public static function make(string $prefix, string $property, string $content)`
`27`	`27`
`28`	`28`	`public function __toString(): string`
`29`	`29`	`{`
`30`		`- return "<meta property=\"{$this->prefix}:{$this->property}\" content=\"{$this->content}\">";`
	`30`	`+ $content = str_replace('"', '"', $this->content);`
	`31`	`+`
	`32`	`+ return "<meta property=\"{$this->prefix}:{$this->property}\" content=\"{$content}\">";`
`31`	`33`	`}`
`32`	`34`	`}`