switch from string to instanceof check to allow stringable objects

Gummibeer · Gummibeer · commit b3e499730756 · 2020-06-09T16:11:38.000+02:00
diff --git a/src/Type.php b/src/Type.php
@@ -78,9 +78,9 @@ public function alternateLocale(string $locale)
     public function image($image)
     {
         $this->addStructuredProperty(
-            is_string($image)
-                ? Image::make($image)
-                : $image
+            $image instanceof Image
+                ? $image
+                : Image::make($image)
         );
 
         return $this;
@@ -93,9 +93,9 @@ public function image($image)
     public function video($video)
     {
         $this->addStructuredProperty(
-            is_string($video)
-                ? Image::make($video)
-                : $video
+            $video instanceof Video
+                ? $video
+                : Video::make($video)
         );
 
         return $this;
@@ -108,9 +108,9 @@ public function video($video)
     public function audio($audio)
     {
         $this->addStructuredProperty(
-            is_string($audio)
-                ? Image::make($audio)
-                : $audio
+            $audio instanceof Audio
+                ? $audio
+                : Audio::make($audio)
         );
 
         return $this;
diff --git a/tests/__snapshots__/GlobalTypesTest__it_can_generate_website_tags_with_stringable_image__1.html b/tests/__snapshots__/GlobalTypesTest__it_can_generate_website_tags_with_stringable_image__1.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
+<html><head>
+<meta property="og:type" content="website">
+<meta property="og:title" content="Title | Example">
+<meta property="og:url" content="http://www.example.com">
+<meta property="og:description" content="Description">
+<meta property="og:locale" content="en_US">
+<meta property="og:locale:alternate" content="en_GB">
+<meta property="og:site_name" content="Example">
+<meta property="og:image:url" content="http://www.example.com/image1.jpg">
+</head></html>
