[BUG] Source Image not working with my Image node

[gonzalu]

Prerequisites

• I have searched existing(open/closed) issues and Read Known Issues / Compatibility to make sure this isn't a duplicate
• I am running the latest version of ComfyUI
• I am running the latest version of ComfyUI_frontend
• I am running the latest version of Resolution Master Github | Manager

What happened?

I am using my own custom random image from folder node and the Resolution Master seems to ignore it :( Tested with native load image node and works.

Can you let me know what I should do to my node to support your node?

My node is here:

https://github.com/gonzalu/ComfyUI_YFG_Comical

Specifically: RandomImageFromDirectory.py

Thanks for your help and an awesome node.

Steps to Reproduce

Install my node pack
add RandomImagefromFolder node
connect to input image in Resolution Master node
Run workflow.

Res Master ignores input image (I believe because no autodetect happens and the output numbers do not change)

How is this affecting you?

Feature doesn't work as expected

Browser

Edge

Console Errors

Logs

Additional Context, Environment (OS, ComfyUI versions, ResolutionMaster version)

No response

[Azornes]

As far as I remember, when I tried to make my LayerForge compatible with Resolution Master, I had to take a look at how the native image loader works in ComfyUI. To be able to read resolutions live, the node needs to have a native preview function added (that’s also why, for LayerForge to work with Resolution Master, the user has to enable the preview option). Therefore, if you want your node to work with Resolution Master, you also need to add a preview function.

[gonzalu]

As far as I remember, when I tried to make my LayerForge compatible with Resolution Master, I had to take a look at how the native image loader works in ComfyUI. To be able to read resolutions live, the node needs to have a native preview function added (that’s also why, for LayerForge to work with Resolution Master, the user has to enable the preview option). Therefore, if you want your node to work with Resolution Master, you also need to add a preview function.

Ah, makes sense, much obliged. Easy enough to do. Let me go play. I will report back results :D

Thank you, @Azornes

[gonzalu]

OK, I added a self preview option to my node and it works. But it's even more radical :D It needs to be physically connected to your node. All the send/receive nodes (no noodles) do not seem to work... :(

Either way, it reduced my workflow from 10 unnecessary nodes :D

Thank you again!

[gonzalu]

Question: The Aspect Ratio does not seem to be working for me... is there something I can be doing wrong still? I using the native way to display preview image.

Thanks

[Azornes]

OK, I added a self preview option to my node and it works. But it's even more radical :D It needs to be physically connected to your node. All the send/receive nodes (no noodles) do not seem to work... :(

Either way, it reduced my workflow from 10 unnecessary nodes :D

Thank you again!

It’s not possible, or I don’t know how, to do this in a way that doesn’t require directly using preview nodes. Preview nodes can load images without using execute/run, and my node needs to have direct access to a selected preview node so it knows which one it’s reading the live image from.

Question: The Aspect Ratio does not seem to be working for me... is there something I can be doing wrong still? I using the native way to display preview image.

Thanks

Could you clarify what exactly not working?
When you choose a preset, does nothing change in the resolutions?

Also, did you watch the video? It shows most of the options and the steps you need to click through.

[gonzalu]

Thank you, yes, watched all videos and looked though all the documentation...

What I mean is, the auto-detect does not seem to be changing the A:R ... maybe I am doing it wrong.

When image loads, the autodetect triggers and the dimensions change and the scaling sets up the outputs but the aspect ratio seems to stay at 1.

I am sure it is on my end, just looking for an idea of what I may be able to do.

Thanks for the help and great node.

[Azornes]

Thanks for the detailed explanation — I think there may be a small misunderstanding here.

This green output is rescale_factor not Aspect Ratio,
The node does not have an output for aspect ratio; it only calculates a scaling factor based on the selected mode.
Understanding rescale_factor Behavior

[gonzalu]

Aha, my bad LOL. I assumed it was aspect ratio. No worries, thank you and cheers!

[gonzalu]

A few more questions. IS there a way to maintain aspect ratio? I have noticed when I select any of the auto modes, if my source image is too tall or too wide the node crops the resulting dimensions not to the same origina A:R ... I understand this might be due to optimal dimensions for the model (Flux.2) but I'd like to have the option if possible to maintain original A:R

One other thing I have noticed is that sometimes a very wide image will be resized as portrait... IS that by design or not?

Thanks again.

[Azornes]

If you want to keep the aspect ratio, just use only the auto-resize option.

It generally shouldn’t switch to portrait. If you can give me specific steps to reproduce this bug, I’ll check in my free time why this is happening.

[gonzalu]

Thank you... let me find the image(s) that I noticed this with and let you know.