Skip to content

Commit e7b602a

Browse files
BKNDLSS-32568 JS SDK ignores Global logger (#241)
1 parent 025c5a0 commit e7b602a

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

src/logging/index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import Logger from './logger'
22

3+
const GLOBAL_LOGGER_NAME = 'Global logger'
4+
35
export default class Logging {
46

57
constructor(app) {
@@ -33,6 +35,8 @@ export default class Logging {
3335
loggers.forEach(logger => {
3436
this.config.levels[logger.name] = logger.level
3537
})
38+
39+
this.config.defaultLevel = this.config.levels[GLOBAL_LOGGER_NAME] || this.config.defaultLevel
3640
})
3741
.catch(error => {
3842
// eslint-disable-next-line no-console

test/unit/specs/logging.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,6 +458,10 @@ describe('<Logging>', function() {
458458
{
459459
name : loggerName,
460460
level: 'FATAL'
461+
},
462+
{
463+
name: 'Global logger',
464+
level: 'ERROR'
461465
}
462466
])
463467

@@ -472,17 +476,25 @@ describe('<Logging>', function() {
472476
}
473477
})
474478

479+
await Utils.wait(1000)
480+
475481
const req = prepareMockRequest()
476482

477483
logger.debug('debug message')
478484
logger.info('info message')
479485
logger.fatal('fatal message')
480486
logger.trace('trace message')
481487

488+
const unregisteredLogger = Backendless.Logging.getLogger('unregistered')
489+
490+
unregisteredLogger.info('should not be flushed')
491+
unregisteredLogger.error('should be flushed')
492+
482493
await Backendless.Logging.flush()
483494

484495
expect(req.body).to.deep.equal([
485496
{ 'log-level': 'FATAL', 'logger': loggerName, 'message': 'fatal message', timestamp: req.body[0].timestamp },
497+
{ 'log-level': 'ERROR', 'logger': 'unregistered', 'message': 'should be flushed', timestamp: req.body[1].timestamp },
486498
])
487499
})
488500

0 commit comments

Comments
 (0)