fix (Data Service): (#97)

- remove unsupported method bulkCreate
- fix method bulkDelete
- add tests for method bulkDelete

Author: illyaV

src/backendless.d.ts

@@ -431,9 +431,6 @@ declare module __Backendless {
         deleteRelationSync(parentObject:Object, columnName:string, childObjectIdArray:Array<string>):string;
         deleteRelationSync(parentObject:Object, columnName:string, whereClause:string):string;
 
-        bulkCreate(objectsArray:Array<Object>):Promise<string>;
-        bulkCreateSync(objectsArray:Array<Object>):string;
-
         bulkUpdate(templateObject:Object, whereClause:string):Promise<string>;
         bulkUpdateSync(templateObject:Object, whereClause:string):string;
 

src/backendless.js

@@ -1546,34 +1546,6 @@
       return url;
     },
 
-    /**
-     * Create of several objects
-     *
-     * @param {object[]} objectsArray - array of objects
-     * @returns {Promise}
-     */
-    bulkCreate: promisified('_bulkCreate'),
-
-    /**
-     * Create of several objects (sync)
-     *
-     * @param {object[]} objectsArray - array of objects
-     * @returns {*}
-     */
-    bulkCreateSync: synchronized('_bulkCreate'),
-
-    _bulkCreate: function(objectsArray, async) {
-      this._validateBulkCreateArg(objectsArray);
-
-      return Backendless._ajax({
-        method      : 'POST',
-        url         : this.bulkRestUrl,
-        data        : JSON.stringify(objectsArray),
-        isAsync     : !!async,
-        asyncHandler: async
-      });
-    },
-
     /**
      * Update of several objects by template
      *
@@ -1633,34 +1605,18 @@
         objects = objectsArray.map(function(obj) {
           return Utils.isString(obj) ? obj : obj.objectId;
         });
+
+        whereClause = 'objectId in (\'' + objects.join('\', \'') + '\')';
       }
 
       return Backendless._ajax({
         method      : 'DELETE',
         url         : this.bulkRestUrl + '?' + Utils.toQueryParams({ where: whereClause }),
-        data        : objects && JSON.stringify(objects),
         isAsync     : !!async,
         asyncHandler: async
       });
     },
 
-    _validateBulkCreateArg: function(objectsArray) {
-      var MSG_ERROR = (
-        'Invalid value for the "objectsArray" argument. ' +
-        'The argument must contain only array of objects.'
-      );
-
-      if (!Utils.isArray(objectsArray)) {
-        throw new Error(MSG_ERROR);
-      }
-
-      for (var i = 0; i < objectsArray.length; i++) {
-        if (!Utils.isObject(objectsArray[i])) {
-          throw new Error(MSG_ERROR);
-        }
-      }
-    },
-
     _validateBulkUpdateArgs: function(templateObject, whereClause) {
       if (!templateObject || !Utils.isObject(templateObject)) {
         throw new Error('Invalid templateObject argument. The first argument must contain object');

test/e2e/specs/persistence.js

@@ -344,6 +344,77 @@ describe('Persistence', function() {
       })
   })
 
+  /**********************
+   *  BULK OPERATIONS   *
+   **********************/
+
+  describe('Bulk operations', function() {
+    const TestTableName = 'MovieAnimal'
+    const testData = [
+      {
+        name: 'Beethoven',
+        kind: 'dog'
+      },
+      {
+        name: 'Rex',
+        kind: 'dog'
+      },
+      {
+        name: 'Lessie',
+        kind: 'dog'
+      },
+      {
+        name: 'Garfield',
+        kind: 'cat'
+      }
+    ]
+
+    let testDataItems
+    let TestTable
+
+    beforeEach(() => {
+        TestTable = Persistence.of(TestTableName)
+        testDataItems = []
+
+        let saveAction = Promise.resolve()
+
+        testData.forEach(data => {
+          saveAction = saveAction
+            .then(() => TestTable.save(data)
+              .then(item => testDataItems.push(item))
+            )
+        })
+
+        return saveAction
+      }
+    )
+
+    it('Bulk delete by where clause', function() {
+      return TestTable.bulkDelete('kind=\'dog\'')
+        .then(result => {
+          expect(result).to.be.equal(3)
+        })
+    })
+
+    it('Bulk delete by array of ids', function() {
+      const ids = testDataItems
+        .filter(item => item.kind === 'dog')
+        .map(item => item.objectId)
+
+      return TestTable.bulkDelete(ids)
+        .then(result => {
+          expect(result).to.be.equal(ids.length)
+        })
+    })
+
+    it('Bulk delete by array of objects', function() {
+      return TestTable.bulkDelete(testDataItems)
+        .then(result => {
+          expect(result).to.be.equal(testDataItems.length)
+        })
+    })
+  })
+
   /****************
    *  RELATIONS   *
    ****************/