Skip to content

Commit 072519d

Browse files
committed
fix: report generator — 11 issues fixed
1. N5 method name: test_ton_sign_with_comment -> test_ton_sign_with_memo (JUnit match) 2. N4 description: remove false "hash verification" claim, describe actual behavior 3. S12: add token_info metadata test (SolanaTokenInfo with USDC mint/symbol) 4. TON section description: remove cell tree reconstruction claim (deferred to 7.15) 5. TON bullet points: CLEAR-SIGN -> STRUCTURED (accurate for current behavior) 6. S5 description: add AdvancedMode requirement note 7. T4 description: clarify blind sign shows amount+address if provided
1 parent 06f5f68 commit 072519d

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

scripts/generate-test-report.py

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ def parse_junit(path):
833833
('S4', 'test_msg_solana_signtx', 'test_solana_sign_system_transfer',
834834
'Sign SOL transfer', 'System::Transfer with full address + amount display.', ['SOL amount + address']),
835835
('S5', 'test_msg_solana_signtx', 'test_solana_sign_message',
836-
'Sign Solana message', 'Arbitrary message signing with Ed25519 key.', ['Message screen']),
836+
'Sign Solana message', 'Arbitrary message signing with Ed25519 key. Requires AdvancedMode policy (no domain separation).', ['Message screen']),
837837
('S6', 'test_msg_solana_signtx', 'test_solana_sign_empty_rejected',
838838
'Empty tx rejected', 'Zero-length transaction data is refused.', []),
839839
('S7', 'test_msg_solana_signtx', 'test_solana_sign_deterministic',
@@ -854,6 +854,10 @@ def parse_junit(path):
854854
'Compute budget unit price',
855855
'Set priority fee for transaction. OLED shows compute unit price.',
856856
['Unit price']),
857+
('S12', 'test_msg_solana_signtx', 'test_solana_sign_token_transfer_with_metadata',
858+
'SPL Token with metadata',
859+
'Token transfer with SolanaTokenInfo (mint, symbol, decimals). OLED shows human-readable token name.',
860+
['Token name + amount']),
857861
]),
858862

859863
('T', 'TRON', '7.14.0',
@@ -873,18 +877,19 @@ def parse_junit(path):
873877
('T3b', 'test_msg_tron_getaddress', 'test_tron_show_address',
874878
'Show address on OLED', 'Full 34-char Base58Check TRON address with QR code.', ['TRON QR + 34-char address']),
875879
('T4', 'test_msg_tron_signtx', 'test_tron_sign_transfer_legacy_raw_data',
876-
'Sign TRX blind (raw_data)', 'Raw protobuf data triggers blind sign path.', ['Blind sign']),
880+
'Sign TRX blind (raw_data)', 'Raw protobuf data triggers blind sign path. Shows amount + address if provided.', ['TRON blind sign']),
877881
('T5', 'test_msg_tron_signtx', 'test_tron_sign_missing_fields_rejected',
878882
'Missing fields rejected', 'Incomplete transaction data is refused.', []),
879883
]),
880884

881885
('N', 'TON', '7.14.0',
882-
'NEW: TON v4r2 wallet contracts. Clear-sign reconstructs cell tree + SHA-256 hash verification. '
883-
'Blind-sign for StateInit deploys or hash mismatch. Memo/comment support.',
886+
'NEW: TON v4r2 wallet contracts. Ed25519 signing with structured field display. '
887+
'Blind-sign for raw transactions. Memo/comment support. '
888+
'Full clear-sign with cell tree reconstruction deferred to 7.15+.',
884889
[
885890
'ADDRESS: m/44\'/607\'/0\' -> full 48-char base64url TON address',
886-
'CLEAR-SIGN: Reconstruct v4r2 cell -> SHA-256 match -> show transfer details',
887-
'BLIND-SIGN: Hash mismatch or deploy -> "BLIND SIGNATURE" warning',
891+
'STRUCTURED: Amount + address + memo shown as display context -> sign',
892+
'BLIND-SIGN: Raw tx without structured fields -> "BLIND SIGNATURE" warning',
888893
],
889894
[
890895
('N1', 'test_msg_ton_getaddress', 'test_ton_get_address',
@@ -896,9 +901,9 @@ def parse_junit(path):
896901
('N3', 'test_msg_ton_getaddress', 'test_ton_address_format',
897902
'Address format validation', 'Bounceable/non-bounceable format check.', []),
898903
('N4', 'test_msg_ton_signtx', 'test_ton_sign_structured',
899-
'Sign TON clear-sign', 'Hash verification passes, shows "TON Transfer" with details.', ['TON Transfer']),
900-
('N5', 'test_msg_ton_signtx', 'test_ton_sign_with_comment',
901-
'Sign TON with memo', 'Comment displayed before signing.', ['Memo display']),
904+
'Sign TON transfer', 'Structured fields shown as display context. Blind-sign with amount + address.', ['TON Transfer']),
905+
('N5', 'test_msg_ton_signtx', 'test_ton_sign_with_memo',
906+
'Sign TON with memo', 'Memo/comment displayed before signing.', ['Memo display']),
902907
('N6', 'test_msg_ton_signtx', 'test_ton_sign_legacy_raw_tx',
903908
'Sign TON blind', 'Raw tx without structured fields triggers blind sign.', ['Blind warning']),
904909
('N7', 'test_msg_ton_signtx', 'test_ton_sign_missing_fields_rejected',

0 commit comments

Comments
 (0)