Skip to content

Commit 23196bf

Browse files
BitHighlanderclaude
andcommitted
fix: use resp.next_index not resp.input_index in Phase 3 loop
ZcashTransparentSig has {signature, next_index}, not input_index. Would have raised AttributeError on any real transparent shielding tx. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0f39150 commit 23196bf

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

keepkeylib/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1702,11 +1702,11 @@ def zcash_sign_pczt(self, address_n, actions, account=None,
17021702
if not transparent_inputs:
17031703
raise Exception(
17041704
"Device sent ZcashTransparentSig but no transparent_inputs provided")
1705-
if resp.input_index >= len(transparent_inputs):
1705+
if resp.next_index >= len(transparent_inputs):
17061706
raise Exception(
17071707
"Device requested transparent input %d but only %d provided"
1708-
% (resp.input_index, len(transparent_inputs)))
1709-
inp = transparent_inputs[resp.input_index]
1708+
% (resp.next_index, len(transparent_inputs)))
1709+
inp = transparent_inputs[resp.next_index]
17101710
resp = self.call(zcash_proto.ZcashTransparentInput(**inp))
17111711

17121712
if isinstance(resp, proto.Failure):

0 commit comments

Comments
 (0)