Skip to content

Commit 81de77b

Browse files
committed
test: unmask FVK reference vectors — derivation bugs fixed
Remove @expectedfailure — the 3 ZIP-32 derivation bugs are now fixed: 1. Child derivation personal: "ZcashIP32Orchard" → "Zcash_ExpandSeed" 2. Domain separator: 0x11 → 0x81 3. Index encoding: big-endian → little-endian (I2LEOSP32)
1 parent b11a326 commit 81de77b

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

tests/test_msg_zcash_orchard.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,11 @@ def test_fvk_field_ranges(self):
6969
rivk_int = bytes_to_int_le(rivk)
7070
self.assertTrue(rivk_int < PALLAS_Q, "rivk must be < Pallas order q, got 0x%064x" % rivk_int)
7171

72-
@unittest.expectedFailure
7372
def test_fvk_reference_vectors(self):
7473
"""FVK must match reference values from the orchard Rust crate.
7574
7675
Uses mnemonic "all all all all all all all all all all all all"
7776
with account 0, which is the standard test seed.
78-
79-
NOTE: expectedFailure because C derivation does not yet match
80-
the orchard Rust crate output byte-for-byte. The seed access
81-
is now correct (storage_getRawSeed), but the ZIP-32 derivation
82-
internals need debugging. Remove once vectors match.
8377
"""
8478
self.setup_mnemonic_allallall()
8579

0 commit comments

Comments
 (0)