Skip to content

Commit aec9ef5

Browse files
committed
fix: pass denom field in MayachainMsgSend (firmware requires has_denom)
1 parent 17a62e8 commit aec9ef5

3 files changed

Lines changed: 1 addition & 5 deletions

File tree

keepkeylib/client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,14 +1096,13 @@ def mayachain_sign_tx(
10961096
raise CallException("Mayachain.MsgSend", "Multiple amounts per send msg not supported")
10971097

10981098
denom = msg['value']['amount'][0]['denom']
1099-
if denom != 'cacao':
1100-
raise CallException("Mayachain.MsgSend", "Unsupported denomination: " + denom)
11011099

11021100
resp = self.call(mayachain_proto.MayachainMsgAck(
11031101
send=mayachain_proto.MayachainMsgSend(
11041102
from_address=msg['value']['from_address'],
11051103
to_address=msg['value']['to_address'],
11061104
amount=int(msg['value']['amount'][0]['amount']),
1105+
denom=denom,
11071106
address_type=types.SPEND,
11081107
)
11091108
))

tests/test_msg_mayachain_getaddress.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
class TestMsgMayaChainGetAddress(common.KeepKeyTest):
1212

13-
@unittest.skip("Expected values need to be captured from emulator - mayachain uses smaya prefix, not tthor")
1413
def test_mayachain_get_address(self):
1514
self.requires_firmware("7.9.1")
1615
self.requires_fullFeature()

tests/test_msg_mayachain_signtx.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ def make_send(from_address, to_address, amount):
2525

2626
class TestMsgMayaChainSignTx(common.KeepKeyTest):
2727

28-
@unittest.skip("Expected values need to be captured from emulator - addresses/signatures differ from thorchain")
2928
def test_mayachain_sign_tx(self):
3029
self.requires_firmware("7.9.1")
3130
self.requires_fullFeature()
@@ -141,7 +140,6 @@ def test_sign_eth_add_liquidity(self):
141140
self.assertEqual(hexlify(sig_r), '638f9f42c099d0d47f7fc70d248249d2db24ecabc2fdee5bf2f5ad73b5bbfd30')
142141
self.assertEqual(hexlify(sig_s), '3dae036aabbe0ec55f7b9e4eef54e2b5335f62544d8c2ed041797a9397f185c7')
143142

144-
@unittest.skip("Expected values need to be captured from emulator - addresses/signatures differ from thorchain")
145143
def test_mayachain_remove_liquidity(self):
146144
self.requires_firmware("7.1.1")
147145
self.requires_fullFeature()

0 commit comments

Comments
 (0)