From dc32840d04b93598a0befb3dbca8a0a40aea2550 Mon Sep 17 00:00:00 2001 From: Blaise Taylor Date: Wed, 4 Feb 2026 10:01:24 -0500 Subject: [PATCH] AB#16 Removing test which invokes mapping.Equals(null);. Removing always true condition. --- .../Serialization/WorkflowMarkupSerializer.cs | 16 +++++++--------- .../WorkflowMarkupSerializerMappingTest.cs | 18 ------------------ 2 files changed, 7 insertions(+), 27 deletions(-) diff --git a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs index d092838..b187d12 100644 --- a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs +++ b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Serialization/WorkflowMarkupSerializer.cs @@ -1401,16 +1401,14 @@ private void DeserializeCompoundProperty(WorkflowMarkupSerializationManager seri if (propValue != null && propValue.GetType() == typeof(string) && ((string)propValue).StartsWith("{}", StringComparison.Ordinal)) propValue = ((string)propValue).Substring(2); - if (property != null) + + try { - try - { - property.SetValue(obj, propValue, null); - } - catch - { - serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, new object[] { propertyName, propertyName, obj.GetType().Name }))); - } + property.SetValue(obj, propValue, null); + } + catch + { + serializationManager.ReportError(new WorkflowMarkupSerializationException(SR.GetString(SR.Error_SerializerComplexPropertySetFailed, new object[] { propertyName, propertyName, obj.GetType().Name }))); } } } diff --git a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Serialization/WorkflowMarkupSerializerMappingTest.cs b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Serialization/WorkflowMarkupSerializerMappingTest.cs index 2a9ce8d..7fe2203 100644 --- a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Serialization/WorkflowMarkupSerializerMappingTest.cs +++ b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Serialization/WorkflowMarkupSerializerMappingTest.cs @@ -373,24 +373,6 @@ public void Equals_WithDifferentUnifiedAssemblyName_ReturnsFalse() Assert.False(result); } - [Fact] - [SuppressMessage("Style", "CA1062:Validate arguments of public methods", Justification = "Testing explicit null handling")] - public void Equals_WithNull_ReturnsFalse() - { - // Arrange - var mapping = new WorkflowMarkupSerializerMapping( - "prefix", - "http://test.namespace.com", - "TestNamespace", - "TestAssembly"); - - // Act - var result = mapping.Equals(null); - - // Assert - Assert.False(result); - } - [Fact] public void Equals_WithSameUnifiedAssemblyName_ReturnsTrue() {