Skip to content

Commit 09b1890

Browse files
committed
v3.3.2:
* adress Mozilla's complaints
1 parent caab664 commit 09b1890

File tree

7 files changed

+43
-16
lines changed

7 files changed

+43
-16
lines changed

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"name": "__MSG_extensionName__",
55
"description": "__MSG_extensionDescription__",
66
"author": "Andreas Bielawski",
7-
"version": "3.3.1",
7+
"version": "3.3.2",
88
"icons": {
99
"16": "icons/16.png",
1010
"32": "icons/32.png",

options/css/bootstrap.min.css

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

options/css/bootstrap.min.css.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

options/css/font-awesome.min.css

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
75.4 KB
Binary file not shown.

options/options.html

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@
33

44
<head>
55
<meta charset="utf-8">
6-
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta/css/bootstrap.min.css" integrity="sha384-/Y6pD6FV/Vv2HJnA6t+vslU6fwYXjCFtcEpHbNJ0lyAFsXTsjBbfaDjzALeQsN6M"
7-
crossorigin="anonymous">
8-
<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet" integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN"
9-
crossorigin="anonymous">
10-
<link href="options.css" rel="stylesheet" />
6+
<link rel="stylesheet" href="css/bootstrap.min.css">
7+
<link rel="stylesheet" href="css/font-awesome.min.css">
8+
<link rel="stylesheet" href="options.css">
119
</head>
1210

1311
<body>

options/options.js

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ function createSpRemoveElement() {
5959
// </a>
6060
const a = $el('a');
6161
a.classList.add('sp-remove', 'input-group-addon');
62-
a.innerHTML = '<i class="fa fa-trash" aria-hidden="true"></i>';
62+
i = document.createElement('i');
63+
i.classList.add('fa', 'fa-trash');
64+
i.setAttribute('aria-hidden', 'true');
65+
a.appendChild(i);
6366
return a;
6467
}
6568

@@ -70,9 +73,14 @@ function createSpStatusElement() {
7073
// </a>
7174
const a = $el('a');
7275
a.classList.add('sp-status', 'input-group-addon');
73-
a.innerHTML = `
74-
<i class="fa fa-check text-success" aria-hidden="true"></i>
75-
<i class="fa fa-times text-danger" aria-hidden="true"></i>`;
76+
i = document.createElement('i');
77+
i.classList.add('fa', 'fa-check', 'text-success');
78+
i.setAttribute('aria-hidden', 'true');
79+
a.appendChild(i);
80+
i = document.createElement('i');
81+
i.classList.add('fa', 'fa-times', 'text-danger');
82+
i.setAttribute('aria-hidden', 'true');
83+
a.appendChild(i);
7684
return a;
7785
}
7886

@@ -184,12 +192,21 @@ function createSpCheckboxElement(selected) {
184192
// </label>
185193
// </span>
186194
const span = $el('span');
187-
span.innerHTML = `
188-
<label class="form-check-label custom-control custom-checkbox">
189-
<input class="form-check-input custom-control-input" type="checkbox" ${selected ? 'checked' : ''}/>
190-
<span class="custom-control-indicator"/>
191-
</label>`;
192-
span.classList.add('sp-selected', 'input-group-addon', 'form-check');
195+
span.classList.add('sp-selected', 'input-group-addon', 'form-check');
196+
197+
label = document.createElement('label');
198+
label.classList.add('form-check-label', 'custom-control', 'custom-checkbox');
199+
span.appendChild(label);
200+
201+
input = document.createElement('input');
202+
input.classList.add('form-check-input', 'custom-control-input');
203+
input.setAttribute('type', 'checkbox');
204+
if (selected) {input.checked = true;} else {input.checked = false;}
205+
label.appendChild(input);
206+
207+
spancci = document.createElement('span');
208+
spancci.classList.add('custom-control-indicator');
209+
label.appendChild(spancci);
193210
return span;
194211
}
195212

0 commit comments

Comments
 (0)