Skip to content

Commit 8a53103

Browse files
Fix Provider class scope
1 parent fdd035f commit 8a53103

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

background.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
class Provider {
1+
var Provider = class Provider {
22
constructor(name = '', icon = '../icons/other.png', url = '', selected = false) {
33
this.name = name;
44
this.icon = icon;
@@ -8,7 +8,7 @@ class Provider {
88
clone() {
99
return new Provider(this.name, this.icon, this.url, this.selected);
1010
}
11-
}
11+
};
1212

1313
const defaultProviders = [
1414
new Provider('Google', '../icons/google.png', 'https://www.google.com/searchbyimage?image_url=%s', true),

options/options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ addSearchProvider.onclick = () => {
194194
const restoreDefaultSearchProviders = $('#restoreDefaultSearchProviders');
195195
restoreDefaultSearchProviders.textContent = chrome.i18n.getMessage('restoreDefaultSearchProviders');
196196
restoreDefaultSearchProviders.onclick = () => {
197-
for (const p of searchProviderList.children) {
198-
p.remove();
197+
while (searchProviderList.firstElementChild) {
198+
searchProviderList.firstElementChild.remove();
199199
}
200200
for (const p of backgroundPage.getDefaultProvidersClone()) {
201201
searchProviderList.appendChild(createSearchProviderElement(p.name, p.icon, p.url, p.selected, false));
@@ -241,7 +241,7 @@ saveOptions.onclick = () => {
241241
return;
242242
}
243243

244-
storedSettings.storageProviders.push(new Provider(name, url, icon, selected));
244+
storedSettings.storageProviders.push(new Provider(name, icon, url, selected));
245245
nameSet.add(name);
246246
}
247247

0 commit comments

Comments
 (0)