Skip to content

Commit 2d61a31

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
Fix features in e2e_non_hosted
NO_IFTTT=no features changed Bug: none Change-Id: Iea087d6d41ba7adcbd8aee299df82020029fcaa2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6895485 Auto-Submit: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org>
1 parent 6714cbc commit 2d61a31

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

test/e2e_non_hosted/conductor/state-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export class StateProvider {
5858

5959
const settings = this.#getSettings(suite);
6060
const browserSettings = {
61-
enabledBlinkFeatures: (settings.enabledBlinkFeatures ?? []).toSorted(),
61+
enabledFeatures: (settings.enabledFeatures ?? []).toSorted(),
6262
disabledFeatures: (settings.disabledFeatures ?? []).toSorted(),
6363
};
6464
const browserKey = JSON.stringify(browserSettings);
@@ -131,7 +131,7 @@ export function mergeSettings(s1: E2E.SuiteSettings, s2: E2E.HarnessSettings): E
131131
}
132132

133133
return {
134-
enabledBlinkFeatures: mergeAsSet(s1.enabledBlinkFeatures, s2.enabledBlinkFeatures),
134+
enabledFeatures: mergeAsSet(s1.enabledFeatures, s2.enabledFeatures),
135135
disabledFeatures: mergeAsSet(s1.disabledFeatures, s2.disabledFeatures),
136136
enabledDevToolsExperiments: mergeAsSet(s1.enabledDevToolsExperiments, s2.enabledDevToolsExperiments),
137137
disabledDevToolsExperiments: mergeAsSet(s1.disabledDevToolsExperiments, s2.disabledDevToolsExperiments),

test/e2e_non_hosted/shared/browser-helper.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class Launcher {
8585

8686
private static launchChrome(settings: BrowserSettings) {
8787
const frontEndDirectory = url.pathToFileURL(path.join(GEN_DIR, 'front_end'));
88-
const disabledFeatures = settings.enabledBlinkFeatures?.slice() ?? [];
88+
const disabledFeatures = settings.disabledFeatures?.slice() ?? [];
8989
const launchArgs = [
9090
'--remote-allow-origins=*',
9191
'--remote-debugging-port=0',
@@ -139,7 +139,7 @@ export class Launcher {
139139
if (!headless) {
140140
launchArgs.push(`--window-size=${windowWidth},${windowHeight}`);
141141
}
142-
const enabledFeatures = settings.enabledBlinkFeatures?.slice() ?? [];
142+
const enabledFeatures = settings.enabledFeatures?.slice() ?? [];
143143
// TODO: remove
144144
const envChromeFeatures = process.env['CHROME_FEATURES'];
145145
if (envChromeFeatures) {
@@ -153,13 +153,13 @@ export class Launcher {
153153
}
154154

155155
export interface BrowserSettings {
156-
enabledBlinkFeatures: string[];
156+
enabledFeatures: string[];
157157
disabledFeatures: string[];
158158
}
159159

160160
export const DEFAULT_BROWSER_SETTINGS: BrowserSettings = {
161161
// LINT.IfChange(features)
162-
enabledBlinkFeatures: [
162+
enabledFeatures: [
163163
'PartitionedCookies',
164164
'SharedStorageAPI',
165165
'FencedFrames',

0 commit comments

Comments
 (0)