Move the Trace SourceMapsResolver into its own model

This will likely change again in the future as szuend@ and others are
working on a consistent approach across DevTools, but my focus currently
is removing UI usage from front_end/models, and this resolver is relied
upon by the Performance Formatters in the AI models directory.

It makes more sense in my opinion to think of the SourceMapsResolver as
a model.

Bypass-Check-License: not new files, just moved existing files
Bug: 443001453
Change-Id: I4d8e7dd71f4cd3efc0fda60a1f8572b3ae9ce9f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6943176
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Author: jackfranklin

config/gni/devtools_grd_files.gni

@@ -618,6 +618,7 @@ grd_files_bundled_sources = [
   "front_end/models/trace/lantern/types/types.js",
   "front_end/models/trace/trace.js",
   "front_end/models/trace/types/types.js",
+  "front_end/models/trace_source_maps_resolver/trace_source_maps_resolver.js",
   "front_end/models/workspace/workspace.js",
   "front_end/models/workspace_diff/workspace_diff.js",
   "front_end/ndb_app.html",
@@ -1265,6 +1266,7 @@ grd_files_unbundled_sources = [
   "front_end/models/trace/types/Overlays.js",
   "front_end/models/trace/types/Timing.js",
   "front_end/models/trace/types/TraceEvents.js",
+  "front_end/models/trace_source_maps_resolver/SourceMapsResolver.js",
   "front_end/models/workspace/FileManager.js",
   "front_end/models/workspace/IgnoreListManager.js",
   "front_end/models/workspace/SearchConfig.js",
@@ -2070,7 +2072,6 @@ grd_files_unbundled_sources = [
   "front_end/panels/timeline/utils/IgnoreList.js",
   "front_end/panels/timeline/utils/ImageCache.js",
   "front_end/panels/timeline/utils/InsightAIContext.js",
-  "front_end/panels/timeline/utils/SourceMapsResolver.js",
   "front_end/panels/timeline/utils/Treemap.js",
   "front_end/panels/web_audio/WebAudioModel.js",
   "front_end/panels/web_audio/WebAudioView.js",

front_end/BUILD.gn

@@ -157,6 +157,7 @@ group("unittests") {
     "models/trace/lantern/metrics:unittests",
     "models/trace/lantern/simulation:unittests",
     "models/trace/types:unittests",
+    "models/trace_source_maps_resolver:unittests",
     "models/workspace:unittests",
     "models/workspace_diff:unittests",
     "panels/accessibility:unittests",

front_end/models/bindings/BUILD.gn

@@ -78,6 +78,7 @@ devtools_entrypoint("bundle") {
     "../issues_manager/*",
     "../persistence/*",
     "../source_map_scopes/*",
+    "../trace_source_maps_resolver/*",
     "../workspace/*",
   ]
 

front_end/models/source_map_scopes/BUILD.gn

@@ -37,6 +37,7 @@ devtools_entrypoint("bundle") {
     "../../ui/components/text_editor/*",
     "../../ui/legacy/components/object_ui/*",
     "../breakpoints/*",
+    "../trace_source_maps_resolver/*",
   ]
 
   visibility += devtools_models_visibility

front_end/models/trace/BUILD.gn

@@ -61,6 +61,7 @@ devtools_entrypoint("bundle") {
     "../../ui/legacy/components/utils/*",
     "../ai_assistance/*",
     "../live-metrics/*",
+    "../trace_source_maps_resolver/*",
     "./*",
   ]
 

front_end/models/trace_source_maps_resolver/BUILD.gn

@@ -0,0 +1,50 @@
+# Copyright 2025 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../../scripts/build/ninja/devtools_entrypoint.gni")
+import("../../../scripts/build/ninja/devtools_module.gni")
+import("../../../scripts/build/typescript/typescript.gni")
+
+devtools_module("trace_source_maps_resolver") {
+  sources = [ "SourceMapsResolver.ts" ]
+
+  deps = [
+    "../../core/platform:bundle",
+    "../../core/sdk:bundle",
+    "../../generated:protocol",
+    "../bindings:bundle",
+    "../source_map_scopes:bundle",
+    "../trace:bundle",
+    "../workspace:bundle",
+  ]
+}
+
+devtools_entrypoint("bundle") {
+  entrypoint = "trace_source_maps_resolver.ts"
+
+  deps = [ ":trace_source_maps_resolver" ]
+
+  visibility = [
+    ":*",
+    "../../panels/timeline/*",
+    "../../testing/*",
+    "../trace:bundle",
+  ]
+}
+
+ts_library("unittests") {
+  testonly = true
+
+  sources = [ "SourceMapsResolver.test.ts" ]
+
+  deps = [
+    ":bundle",
+    "../../core/platform:bundle",
+    "../../core/sdk:bundle",
+    "../../testing",
+    "../bindings:bundle",
+    "../trace:bundle",
+    "../workspace:bundle",
+  ]
+}

…imeline/utils/SourceMapsResolver.test.ts …maps_resolver/SourceMapsResolver.test.tsfront_end/panels/timeline/utils/SourceMapsResolver.test.ts renamed to front_end/models/trace_source_maps_resolver/SourceMapsResolver.test.ts front_end/panels/timeline/utils/SourceMapsResolver.test.ts renamed to front_end/models/trace_source_maps_resolver/SourceMapsResolver.test.ts

@@ -2,29 +2,31 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type {Chrome} from '../../../../extension-api/ExtensionAPI.js';
-import * as Platform from '../../../core/platform/platform.js';
-import * as SDK from '../../../core/sdk/sdk.js';
-import type * as Protocol from '../../../generated/protocol.js';
-import * as Bindings from '../../../models/bindings/bindings.js';
-import * as Trace from '../../../models/trace/trace.js';
-import * as Workspace from '../../../models/workspace/workspace.js';
-import {createTarget} from '../../../testing/EnvironmentHelpers.js';
-import {TestPlugin} from '../../../testing/LanguagePluginHelpers.js';
+import type {Chrome} from '../../../extension-api/ExtensionAPI.js';
+import * as Platform from '../../core/platform/platform.js';
+import * as SDK from '../../core/sdk/sdk.js';
+import type * as Protocol from '../../generated/protocol.js';
+import * as Bindings from '../../models/bindings/bindings.js';
+import * as Trace from '../../models/trace/trace.js';
+import * as Workspace from '../../models/workspace/workspace.js';
+import {createTarget} from '../../testing/EnvironmentHelpers.js';
+import {TestPlugin} from '../../testing/LanguagePluginHelpers.js';
 import {
   describeWithMockConnection,
-} from '../../../testing/MockConnection.js';
-import {MockProtocolBackend} from '../../../testing/MockScopeChain.js';
-import {encodeSourceMap} from '../../../testing/SourceMapEncoder.js';
-import {loadBasicSourceMapExample} from '../../../testing/SourceMapHelpers.js';
+} from '../../testing/MockConnection.js';
+import {MockProtocolBackend} from '../../testing/MockScopeChain.js';
+import {encodeSourceMap} from '../../testing/SourceMapEncoder.js';
+import {loadBasicSourceMapExample} from '../../testing/SourceMapHelpers.js';
 import {
   makeMockRendererHandlerData,
   makeMockSamplesHandlerData,
   makeProfileCall,
-} from '../../../testing/TraceHelpers.js';
-import {TraceLoader} from '../../../testing/TraceLoader.js';
+} from '../../testing/TraceHelpers.js';
+import {TraceLoader} from '../../testing/TraceLoader.js';
 
-import * as Utils from './utils.js';
+import * as TraceSourceMapsResolver from './trace_source_maps_resolver.js';
+
+const {SourceMapsResolver, SourceMappingsUpdated} = TraceSourceMapsResolver;
 
 const {urlString} = Platform.DevToolsPath;
 const MINIFIED_FUNCTION_NAME = 'minified';
@@ -153,7 +155,7 @@ describeWithMockConnection('SourceMapsResolver', () => {
 
     it('renames nodes from the profile models when the corresponding scripts and source maps have loaded',
        async function() {
-         const resolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTrace);
+         const resolver = new SourceMapsResolver(parsedTrace);
 
          // Test the node's name is minified before the script and source maps load.
          assert.strictEqual(
@@ -172,8 +174,7 @@ describeWithMockConnection('SourceMapsResolver', () => {
 
          // Ensure we populate the cache
          assert.strictEqual(
-             Utils.SourceMapsResolver.SourceMapsResolver.resolvedCodeLocationForEntry(profileCallForNameResolving)
-                 ?.name,
+             SourceMapsResolver.resolvedCodeLocationForEntry(profileCallForNameResolving)?.name,
              AUTHORED_FUNCTION_NAME);
        });
 
@@ -195,7 +196,7 @@ describeWithMockConnection('SourceMapsResolver', () => {
 
       const {pluginManager} = Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance();
       pluginManager.addPlugin(new Plugin());
-      const resolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTrace);
+      const resolver = new SourceMapsResolver(parsedTrace);
       await resolver.install();
       assert.strictEqual(
           Trace.Handlers.ModelHandlers.Samples.getProfileCallFunctionName(
@@ -233,19 +234,17 @@ describeWithMockConnection('SourceMapsResolver', () => {
       // For a profile call with mappings, it must return the mapped script.
       const parsedTraceWithMappings = parsedTraceFromProfileCalls([profileCallWithMappings]);
       const mapperWithMappings = new Trace.EntityMapper.EntityMapper(parsedTraceWithMappings);
-      let resolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTraceWithMappings, mapperWithMappings);
+      let resolver = new SourceMapsResolver(parsedTraceWithMappings, mapperWithMappings);
       await resolver.install();
-      let sourceMappedURL = Utils.SourceMapsResolver.SourceMapsResolver.resolvedURLForEntry(
-          parsedTraceWithMappings, profileCallWithMappings);
+      let sourceMappedURL = SourceMapsResolver.resolvedURLForEntry(parsedTraceWithMappings, profileCallWithMappings);
       assert.strictEqual(sourceMappedURL, authoredScriptURL);
 
       // For a profile call without mappings, it must return the original URL
       const parsedTraceWithoutMappings = parsedTraceFromProfileCalls([profileCallWithNoMappings]);
       const mapperWithoutMappings = new Trace.EntityMapper.EntityMapper(parsedTraceWithoutMappings);
-      resolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTraceWithoutMappings, mapperWithoutMappings);
+      resolver = new SourceMapsResolver(parsedTraceWithoutMappings, mapperWithoutMappings);
       await resolver.install();
-      sourceMappedURL = Utils.SourceMapsResolver.SourceMapsResolver.resolvedURLForEntry(
-          parsedTraceWithoutMappings, profileCallWithNoMappings);
+      sourceMappedURL = SourceMapsResolver.resolvedURLForEntry(parsedTraceWithoutMappings, profileCallWithNoMappings);
       assert.strictEqual(sourceMappedURL, genScriptURL);
     });
   });
@@ -254,8 +253,8 @@ describeWithMockConnection('SourceMapsResolver', () => {
       const parsedTrace = await TraceLoader.traceEngine(this, 'user-timings.json.gz');
       const listener = sinon.spy();
 
-      const sourceMapsResolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTrace);
-      sourceMapsResolver.addEventListener(Utils.SourceMapsResolver.SourceMappingsUpdated.eventName, listener);
+      const sourceMapsResolver = new SourceMapsResolver(parsedTrace);
+      sourceMapsResolver.addEventListener(SourceMappingsUpdated.eventName, listener);
       await sourceMapsResolver.install();
       sinon.assert.notCalled(listener);
     });
@@ -306,7 +305,7 @@ describeWithMockConnection('SourceMapsResolver', () => {
       mapper.mappings().eventsByEntity.set(testEntity, [profileCall, profileCallUnmapped]);
       mapper.mappings().createdEntityCache.set('example-domain.com', testEntity);
 
-      const resolver = new Utils.SourceMapsResolver.SourceMapsResolver(parsedTrace, mapper);
+      const resolver = new SourceMapsResolver(parsedTrace, mapper);
       // This should update the entities
       await resolver.install();
       const afterEntityOfEvent = mapper.entityForEvent(profileCall);

…els/timeline/utils/SourceMapsResolver.ts …urce_maps_resolver/SourceMapsResolver.tsfront_end/panels/timeline/utils/SourceMapsResolver.ts renamed to front_end/models/trace_source_maps_resolver/SourceMapsResolver.ts front_end/panels/timeline/utils/SourceMapsResolver.ts renamed to front_end/models/trace_source_maps_resolver/SourceMapsResolver.ts

@@ -2,13 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Platform from '../../../core/platform/platform.js';
-import * as SDK from '../../../core/sdk/sdk.js';
-import type * as Protocol from '../../../generated/protocol.js';
-import * as Bindings from '../../../models/bindings/bindings.js';
-import * as SourceMapScopes from '../../../models/source_map_scopes/source_map_scopes.js';
-import * as Trace from '../../../models/trace/trace.js';
-import * as Workspace from '../../../models/workspace/workspace.js';
+import type * as Platform from '../../core/platform/platform.js';
+import * as SDK from '../../core/sdk/sdk.js';
+import type * as Protocol from '../../generated/protocol.js';
+import * as Bindings from '../bindings/bindings.js';
+import * as SourceMapScopes from '../source_map_scopes/source_map_scopes.js';
+import * as Trace from '../trace/trace.js';
+import * as Workspace from '../workspace/workspace.js';
 
 interface ResolvedCodeLocationData {
   name: string|null;

front_end/models/trace_source_maps_resolver/trace_source_maps_resolver.ts

@@ -0,0 +1,5 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+export * from './SourceMapsResolver.js';

front_end/models/workspace/BUILD.gn

@@ -67,6 +67,7 @@ devtools_entrypoint("bundle") {
     "../persistence/*",
     "../source_map_scopes/*",
     "../stack_trace/*",
+    "../trace_source_maps_resolver/*",
     "../workspace_diff/*",
   ]