[cleanup] Remove redundant code and force reset TrackingAsyncActivity

Extracted from https://crrev.com/c/6884624 but that does
a lot of changes that affect order of things.
So reducing the scope.

Bug: none
Change-Id: I45164b6c477d25a2f616b38191985cdf1ebb69ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6897849
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>

Author: Lightning00Blade

front_end/core/host/AidaClient.test.ts

@@ -559,10 +559,6 @@ describeWithEnvironment('AidaClient', () => {
       });
     }
 
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('should return NO_INTERNET when navigator is not online', async () => {
       const navigatorDescriptor = Object.getOwnPropertyDescriptor(globalThis, 'navigator')!;
       Object.defineProperty(globalThis, 'navigator', {
@@ -631,10 +627,6 @@ describeWithEnvironment('AidaClient', () => {
   });
 
   describe('completeCode', () => {
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('handles successful response', async () => {
       const mockResult: AidaCodeCompleteResult = {
         response: JSON.stringify({

front_end/models/ai_assistance/EvaluateAction.test.ts

@@ -43,10 +43,6 @@ describe('FreestylerEvaluateAction', () => {
       };
     }
 
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('should serialize a CDP error as a string', async () => {
       assert.strictEqual(await executeWithResult({error: 'errorMessage'}), 'Error: errorMessage');
     });

front_end/models/ai_assistance/agents/AiAgent.test.ts

@@ -55,10 +55,6 @@ describeWithEnvironment('AiAgent', () => {
       sinon.stub(crypto, 'randomUUID').returns('sessionId' as `${string}-${string}-${string}-${string}-${string}`);
     });
 
-    afterEach(() => {
-      sinon.restore();
-    });
-
     it('builds a request with a temperature', async () => {
       const agent = new AiAgentMock({
         aidaClient: mockAidaClient(),

front_end/models/ai_assistance/agents/FileAgent.test.ts

@@ -38,15 +38,7 @@ describeWithMockConnection('FileAgent', () => {
     });
   });
 
-  afterEach(() => {
-    sinon.restore();
-  });
-
   describe('buildRequest', () => {
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('builds a request with a model id', async () => {
       mockHostConfig('test model');
       const agent = new FileAgent({

front_end/models/ai_assistance/agents/NetworkAgent.test.ts

@@ -43,10 +43,6 @@ describeWithMockConnection('NetworkAgent', () => {
   });
 
   describe('buildRequest', () => {
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('builds a request with a model id', async () => {
       mockHostConfig('test model');
       const agent = new NetworkAgent({
@@ -134,10 +130,6 @@ describeWithMockConnection('NetworkAgent', () => {
           });
     });
 
-    afterEach(() => {
-      sinon.restore();
-    });
-
     it('generates an answer', async () => {
       const agent = new NetworkAgent({
         aidaClient: mockAidaClient([[{

front_end/models/ai_assistance/agents/PerformanceAgent.test.ts

@@ -38,10 +38,6 @@ describeWithEnvironment('PerformanceAgent', () => {
   }
 
   describe('buildRequest', () => {
-    beforeEach(() => {
-      sinon.restore();
-    });
-
     it('builds a request with a model id', async () => {
       mockHostConfig('test model');
       const agent = new PerformanceAgent(

front_end/models/ai_assistance/agents/StylingAgent.test.ts

@@ -125,10 +125,6 @@ describeWithEnvironment('StylingAgent', () => {
       sinon.stub(crypto, 'randomUUID').returns('sessionId' as `${string}-${string}-${string}-${string}-${string}`);
     });
 
-    afterEach(() => {
-      sinon.restore();
-    });
-
     it('builds a request with a model id', async () => {
       mockHostConfig('test model');
       const agent = new StylingAgent({

front_end/models/ai_code_completion/AiCodeCompletion.test.ts

@@ -27,7 +27,7 @@ describeWithEnvironment('AiCodeCompletion', () => {
   });
 
   afterEach(() => {
-    sinon.restore();
+    clock.restore();
   });
 
   it('builds a request and calls the AIDA client on text changed', async () => {

front_end/panels/application/StorageView.test.ts

@@ -25,6 +25,9 @@ describeWithMockConnection('StorageView', () => {
     domStorageModel = target.model(Resources.DOMStorageModel.DOMStorageModel);
     domStorageModel?.enable();
     storageKeyManager = target.model(SDK.StorageKeyManager.StorageKeyManager);
+    sinon.stub(target.networkAgent(), 'invoke_getCookies').returns(Promise.resolve({
+      cookies: [] as Protocol.Network.Cookie[],
+    } as Protocol.Network.GetCookiesResponse));
   });
 
   expectConsoleLogs({

front_end/panels/common/AiCodeCompletionDisclaimer.test.ts

@@ -21,10 +21,6 @@ describeWithEnvironment('AiCodeCompletionDisclaimer', () => {
     return {view, widget};
   }
 
-  afterEach(() => {
-    sinon.restore();
-  });
-
   it('should show disclaimer with no logging text when enterprise policy value is ALLOW_WITHOUT_LOGGING', async () => {
     updateHostConfig({
       aidaAvailability: {enterprisePolicyValue: Root.Runtime.GenAiEnterprisePolicyValue.ALLOW_WITHOUT_LOGGING},