[AI] AgentFocus.full() now takes all insight sets

Instead of having the caller decide which insight set to use (we are
currently constrained to use only one), let's make that decision in one
place. Keeps it consistent.

Bug: 425270067
Change-Id: I58ff3443d21253dadd0117cea30e30c1cee74629
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6885877
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>

Author: Connor Clark

front_end/models/ai_assistance/agents/PerformanceAgent.test.ts

@@ -751,9 +751,7 @@ describeWithEnvironment('PerformanceAgent – all focus', () => {
   it('uses the min and max bounds of the trace as the origin', async function() {
     const {parsedTrace, insights, metadata} = await TraceLoader.traceEngine(this, 'lcp-images.json.gz');
     assert.isOk(insights);
-    const [firstNav] = parsedTrace.Meta.mainFrameNavigations;
-    const insightSet = getInsightSetOrError(insights, firstNav);
-    const context = PerformanceTraceContext.full(parsedTrace, insightSet, metadata);
+    const context = PerformanceTraceContext.full(parsedTrace, insights, metadata);
     assert.strictEqual(context.getOrigin(), 'trace-658799706428-658804825864');
   });
 });

front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -286,9 +286,9 @@ enum ScorePriority {
 
 export class PerformanceTraceContext extends ConversationContext<TimelineUtils.AIContext.AgentFocus> {
   static full(
-      parsedTrace: Trace.Handlers.Types.ParsedTrace, insightSet: Trace.Insights.Types.InsightSet|null,
+      parsedTrace: Trace.Handlers.Types.ParsedTrace, insights: Trace.Insights.Types.TraceInsightSets,
       traceMetadata: Trace.Types.File.MetaData): PerformanceTraceContext {
-    return new PerformanceTraceContext(TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insightSet, traceMetadata));
+    return new PerformanceTraceContext(TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insights, traceMetadata));
   }
 
   static fromInsight(

front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.test.ts

@@ -5,7 +5,6 @@
 import * as Trace from '../../../models/trace/trace.js';
 import * as TimelineUtils from '../../../panels/timeline/utils/utils.js';
 import {describeWithEnvironment} from '../../../testing/EnvironmentHelpers.js';
-import {getFirstOrError} from '../../../testing/InsightHelpers.js';
 import {SnapshotTester} from '../../../testing/SnapshotTester.js';
 import {TraceLoader} from '../../../testing/TraceLoader.js';
 import {PerformanceTraceFormatter} from '../ai_assistance.js';
@@ -14,8 +13,7 @@ async function createFormatter(context: Mocha.Context|Mocha.Suite|null, name: st
     Promise<{formatter: PerformanceTraceFormatter, parsedTrace: Trace.Handlers.Types.ParsedTrace}> {
   const {parsedTrace, insights, metadata} = await TraceLoader.traceEngine(context, name);
   assert.isOk(insights);
-  const insightSet = getFirstOrError(insights.values());
-  const focus = TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insightSet, metadata);
+  const focus = TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insights, metadata);
   const eventsSerializer = new TimelineUtils.EventsSerializer.EventsSerializer();
   const formatter = new PerformanceTraceFormatter(focus, eventsSerializer);
   return {formatter, parsedTrace};

front_end/panels/timeline/TimelinePanel.ts

@@ -1167,9 +1167,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
       return;
     }
 
-    // Currently only support a single insight set.
-    const insightSet = [...insights.values()].at(0) ?? null;
-    const context = Utils.AIContext.AgentFocus.full(parsedTrace, insightSet, traceMetadata);
+    const context = Utils.AIContext.AgentFocus.full(parsedTrace, insights, traceMetadata);
     UI.Context.Context.instance().setFlavor(Utils.AIContext.AgentFocus, context);
 
     // Trigger the AI Assistance panel to open.

front_end/panels/timeline/utils/AIContext.ts

@@ -30,8 +30,10 @@ type AgentFocusData = AgentFocusDataCallTree|AgentFocusDataInsight|AgentFocusDat
 
 export class AgentFocus {
   static full(
-      parsedTrace: Trace.Handlers.Types.ParsedTrace, insightSet: Trace.Insights.Types.InsightSet|null,
+      parsedTrace: Trace.Handlers.Types.ParsedTrace, insights: Trace.Insights.Types.TraceInsightSets,
       traceMetadata: Trace.Types.File.MetaData): AgentFocus {
+    // Currently only support a single insight set. Pick the first one with a navigation.
+    const insightSet = [...insights.values()].filter(insightSet => insightSet.navigation).at(0) ?? null;
     return new AgentFocus({
       type: 'full',
       parsedTrace,

front_end/services/tracing/ExternalRequests.ts

@@ -66,9 +66,6 @@ export async function getPerformanceAgentFocusToDebug(model: Trace.TraceModel.Mo
     };
   }
 
-  // Currently only support a single insight set.
-  const insightSet = [...insights.values()].at(0) ?? null;
-
-  const focus = TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insightSet, traceMetadata);
+  const focus = TimelineUtils.AIContext.AgentFocus.full(parsedTrace, insights, traceMetadata);
   return {focus};
 }