Skip to content

Commit dab75e1

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8705202681120367313 R=chrome-devtools-waterfall-gardener-emea-oncall@google.com Bug: none Change-Id: Ide0c66ee1da3a3b5690fa6213e882530f5417744 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6895608 Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
1 parent 94a3c6c commit dab75e1

File tree

8 files changed

+26
-10
lines changed

8 files changed

+26
-10
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '07272ab9a30fd555890fda0718f4c2c25931653a',
2525

2626
# Keeping track of the last time we rolled the browser protocol files.
27-
'chromium_browser_protocol_revision' : '693f11acd8869001ff0a6c71faca293cd65afd0b',
27+
'chromium_browser_protocol_revision' : '67b3be36a4efb989a69c585f68bee1d86f193768',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/generated/InspectorBackendCommands.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/generated/protocol-mapping.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1227,7 +1227,7 @@ export namespace ProtocolMapping {
12271227
returnType: void;
12281228
};
12291229
/**
1230-
* Set permission settings for given origin.
1230+
* Set permission settings for given requesting and embedding origins.
12311231
*/
12321232
'Browser.setPermission': {
12331233
paramsType: [Protocol.Browser.SetPermissionRequest];

front_end/generated/protocol-proxy-api.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ declare namespace ProtocolProxyApi {
591591

592592
export interface BrowserApi {
593593
/**
594-
* Set permission settings for given origin.
594+
* Set permission settings for given requesting and embedding origins.
595595
*/
596596
invoke_setPermission(params: Protocol.Browser.SetPermissionRequest): Promise<Protocol.ProtocolResponseWithError>;
597597

front_end/generated/protocol.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2263,9 +2263,15 @@ export namespace Browser {
22632263
*/
22642264
setting: PermissionSetting;
22652265
/**
2266-
* Origin the permission applies to, all origins if not specified.
2266+
* Requesting origin the permission applies to, all origins if not specified.
22672267
*/
22682268
origin?: string;
2269+
/**
2270+
* Embedding origin the permission applies to. It is ignored unless the requesting origin is
2271+
* present and valid. If the requesting origin is provided but the embedding origin isn't, the
2272+
* requesting origin is used as the embedding origin.
2273+
*/
2274+
embeddingOrigin?: string;
22692275
/**
22702276
* Context to override. When omitted, default browser context is used.
22712277
*/

front_end/third_party/chromium/README.chromium

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Name: Dependencies sourced from the upstream `chromium` repository
22
URL: https://source.chromium.org/chromium/chromium/src/+/main:components/variations/proto/devtools/
33
Version: N/A
4-
Revision: 693f11acd8869001ff0a6c71faca293cd65afd0b
4+
Revision: 67b3be36a4efb989a69c585f68bee1d86f193768
55
Update Mechanism: Manual (https://crbug.com/428069060)
66
License: BSD-3-Clause
77
License File: LICENSE

third_party/blink/public/devtools_protocol/browser_protocol.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3506,7 +3506,7 @@
35063506
"commands": [
35073507
{
35083508
"name": "setPermission",
3509-
"description": "Set permission settings for given origin.",
3509+
"description": "Set permission settings for given requesting and embedding origins.",
35103510
"experimental": true,
35113511
"parameters": [
35123512
{
@@ -3521,7 +3521,13 @@
35213521
},
35223522
{
35233523
"name": "origin",
3524-
"description": "Origin the permission applies to, all origins if not specified.",
3524+
"description": "Requesting origin the permission applies to, all origins if not specified.",
3525+
"optional": true,
3526+
"type": "string"
3527+
},
3528+
{
3529+
"name": "embeddingOrigin",
3530+
"description": "Embedding origin the permission applies to. It is ignored unless the requesting origin is\npresent and valid. If the requesting origin is provided but the embedding origin isn't, the\nrequesting origin is used as the embedding origin.",
35253531
"optional": true,
35263532
"type": "string"
35273533
},

third_party/blink/public/devtools_protocol/domains/Browser.pdl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,19 @@ domain Browser
103103
closeTabSearch
104104
openGlic
105105

106-
# Set permission settings for given origin.
106+
# Set permission settings for given requesting and embedding origins.
107107
experimental command setPermission
108108
parameters
109109
# Descriptor of permission to override.
110110
PermissionDescriptor permission
111111
# Setting of the permission.
112112
PermissionSetting setting
113-
# Origin the permission applies to, all origins if not specified.
113+
# Requesting origin the permission applies to, all origins if not specified.
114114
optional string origin
115+
# Embedding origin the permission applies to. It is ignored unless the requesting origin is
116+
# present and valid. If the requesting origin is provided but the embedding origin isn't, the
117+
# requesting origin is used as the embedding origin.
118+
optional string embeddingOrigin
115119
# Context to override. When omitted, default browser context is used.
116120
optional BrowserContextID browserContextId
117121

0 commit comments

Comments
 (0)