Skip to content

Commit eb06387

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Remove timeout from Dock change announcement
We can use the UI Binding callback to issue the A11Y announcement, that way we know that the docking changed, if we didn't change docking we will immediately issue the announcement https://crsrc.org/c/chrome/browser/devtools/devtools_window.cc;l=1637 Bug: none Change-Id: I91e64793c7260e9074afecd4127040bdcc3a81d9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6897850 Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org> Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org> Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
1 parent 1ce5add commit eb06387

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front_end/ui/legacy/DockController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ export class DockController extends Common.ObjectWrapper.ObjectWrapper<EventType
116116

117117
private dockSideChanged(): void {
118118
this.setDockSide(this.currentDockStateSetting.get());
119-
setTimeout(this.announceDockLocation.bind(this), 2000);
120119
}
121120

122121
dockSide(): DockState|undefined {
@@ -169,6 +168,7 @@ export class DockController extends Common.ObjectWrapper.ObjectWrapper<EventType
169168

170169
private setIsDockedResponse(eventData: ChangeEvent): void {
171170
this.dispatchEventToListeners(Events.AFTER_DOCK_SIDE_CHANGED, eventData);
171+
this.announceDockLocation();
172172
}
173173

174174
toggleDockSide(): void {

0 commit comments

Comments
 (0)