From c2d77122a63bb463371644892a27b21c51affc4e Mon Sep 17 00:00:00 2001 From: ameer2468 <33054370+ameer2468@users.noreply.github.com> Date: Fri, 17 Oct 2025 15:20:46 +0300 Subject: [PATCH 1/3] hide icon when removing --- .../settings/account/components/ProfileImage.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx b/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx index e401c3a68b..34ef6505c2 100644 --- a/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx +++ b/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx @@ -124,10 +124,12 @@ export function ProfileImage({ onClick={handleRemove} spinner={isRemoving} > - + {isRemoving ? null : ( + + )} )} From 4cdc50d9c1332f1370b984d0835967ec69b50af8 Mon Sep 17 00:00:00 2001 From: ameer2468 <33054370+ameer2468@users.noreply.github.com> Date: Fri, 17 Oct 2025 15:40:45 +0300 Subject: [PATCH 2/3] update skeleton --- .../account/components/ProfileImage.tsx | 24 ++-- .../dashboard/settings/account/loading.tsx | 136 +++++++++++++----- 2 files changed, 112 insertions(+), 48 deletions(-) diff --git a/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx b/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx index 34ef6505c2..a1cdcec999 100644 --- a/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx +++ b/apps/web/app/(org)/dashboard/settings/account/components/ProfileImage.tsx @@ -101,25 +101,23 @@ export function ProfileImage({ />
- {!isRemoving && ( - - )} + {(previewUrl || isRemoving) && ( diff --git a/packages/ui/src/components/Button.tsx b/packages/ui/src/components/Button.tsx index ea83036983..45f322dfab 100644 --- a/packages/ui/src/components/Button.tsx +++ b/packages/ui/src/components/Button.tsx @@ -49,6 +49,7 @@ export interface ButtonProps asChild?: boolean; spinner?: boolean; href?: string; + spinnerClassName?: string; kbd?: string; icon?: React.ReactNode; target?: string; @@ -62,6 +63,7 @@ const Button = React.forwardRef( size, asChild = false, spinner = false, + spinnerClassName, href, kbd, icon, @@ -79,7 +81,12 @@ const Button = React.forwardRef( href={href || undefined} {...props} > - {spinner && } + {spinner && ( + + )} {icon && icon} {props.children} {kbd && (