Rebuild Node/Nodesource Feature

Now requires a specific semver version string which improves overall
reliability and clarity in what Node.js version is being installed.

The default “automatic” will install the latest Node.js v24 (current
LTS release) and generally shouldn’t be used, but if you _really_ don’t
care, you can use the default.

Also, run `chown` during the `onCreateCommand` lifecycle hook to free
up relying Dev Containers to use the `updateContentCommand` hook.

Author: jgarber623-cargosense

src/node/README.md

@@ -6,15 +6,15 @@ Install [Node.js](https://nodejs.org) from [Nodesource's DEB repository](https:/
 
 ```json
 "features": {
-  "ghcr.io/CargoSense/devcontainer-features/node:2": {}
+  "ghcr.io/CargoSense/devcontainer-features/node:3": {}
 }
 ```
 
 ## Options
 
 | Option ID | Description                     | Type   | Default Value |
 |:----------|:--------------------------------|:-------|:--------------|
-| `version` | The Node.js version to install. | string | `24`          |
+| `version` | The Node.js version to install. | string | `automatic`   |
 
 ## OS Support
 

src/node/devcontainer-feature.json

@@ -1,21 +1,13 @@
 {
   "name": "Node.js",
   "id": "node",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "description": "Install Node.js from Nodesource's DEB repository.",
   "options": {
     "version": {
       "type": "string",
-      "enum": [
-        "20",
-        "21",
-        "22",
-        "23",
-        "24",
-        "25"
-      ],
-      "default": "24",
-      "description": "Select or enter a Node.js version."
+      "default": "automatic",
+      "description": "The Node.js version to install."
     }
   },
   "containerEnv": {
@@ -36,5 +28,5 @@
       "type": "volume"
     }
   ],
-  "postCreateCommand": "sudo chown -R ${USER}:${USER} /usr/local/npm ${containerWorkspaceFolder}/node_modules"
+  "onCreateCommand": "sudo chown -R ${USER}:${USER} /usr/local/npm ${containerWorkspaceFolder}/node_modules"
 }

src/node/install.sh

@@ -1,23 +1,70 @@
-#!/usr/bin/env sh
+#!/usr/bin/env bash
 
 set -e
 
-NODE_VERSION="${VERSION:-"24"}"
+NODE_VERSION="${VERSION:-"automatic"}"
+NODE_MAJOR_VERSION="24"
+
+pkg="nodejs"
+
+if [ "${NODE_VERSION}" != "automatic" ]; then
+  NODE_MAJOR_VERSION="$(echo "${NODE_VERSION}" | cut -d. -f1)"
+  pkg="${pkg}=${NODE_VERSION}-1nodesource1"
+fi
 
 curl_installed=""
+gpg_installed=""
 
 if ! type curl >/dev/null 2>&1; then
   apt update --yes
-  apt install --no-install-recommends --yes curl ca-certificates
+  apt install --yes curl
 
   curl_installed="true"
 fi
 
-curl -fsSL https://deb.nodesource.com/setup_"${NODE_VERSION}".x | bash -
+if ! type gpg >/dev/null 2>&1; then
+  apt update --yes
+  apt install --yes gnupg
 
-apt update --yes
-apt install --no-install-recommends --yes nodejs
+  gpg_installed="true"
+fi
+
+apt_sources_snippet="$(cat << EOF
+Types: deb
+URIs: https://deb.nodesource.com/node_${NODE_MAJOR_VERSION}.x
+Suites: nodistro
+Components: main
+Signed-By: /etc/apt/keyrings/nodesource.gpg
+EOF
+)"
+
+install -dm 755 /etc/apt/keyrings
+curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
+echo "${apt_sources_snippet}" | tee /etc/apt/sources.list.d/nodesource.sources
 
 if [ -n "${curl_installed}" ]; then
   apt purge curl --autoremove --yes
+  rm -rf /var/lib/apt/lists/*
+fi
+
+if [ -n "${gpg_installed}" ]; then
+  apt purge gnupg --autoremove --yes
+  rm -rf /var/lib/apt/lists/*
+fi
+
+apt update --yes
+apt install --yes "${pkg}"
+rm -rf /var/lib/apt/lists/*
+
+node_rc_snippet="$(cat << EOF
+export NODE_VERSION="$(node -v | cut -c2-)"
+EOF
+)"
+
+if [[ "$(cat /etc/bash.bashrc)" != *"${node_rc_snippet}"* ]]; then
+  echo "${node_rc_snippet}" >> /etc/bash.bashrc
+fi
+
+if [ -f "/etc/zsh/zshrc" ] && [[ "$(cat /etc/zsh/zshrc)" != *"${node_rc_snippet}"* ]]; then
+  echo "${node_rc_snippet}" >> /etc/zsh/zshrc
 fi

test/node/node-20.sh

@@ -7,7 +7,7 @@ set -e
 source dev-container-features-test-lib
 
 # Feature-specific tests
-check "version" bash -c "node --version | grep -E 'v20\..+'"
+check "version" bash -c "node --version | grep v20.1.0"
 
 # Report result
 reportResults

test/node/scenarios.json

@@ -3,7 +3,7 @@
     "image": "mcr.microsoft.com/devcontainers/base:debian",
     "features": {
       "node": {
-        "version": "20"
+        "version": "20.1.0"
       }
     }
   }