Add an extra line to the default store file to prevent a vulnerability

Author: ChainsDD

src/com/noshufou/android/su/HomeActivity.java

@@ -95,6 +95,7 @@ protected void onCreate(Bundle savedInstanceState) {
         ChangeLog cl = new ChangeLog(this);
         if (cl.firstRun()) {
             cl.getLogDialog().show();
+            Util.writeDetaultStoreFile(this);
         }
 
         // Check for root enabled on CyanogenMod 9

src/com/noshufou/android/su/preferences/PreferencesActivity.java

@@ -284,7 +284,7 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences,
             mToastLocation.setEnabled(sharedPreferences
                     .getString(Preferences.NOTIFICATION_TYPE, "toast").equals("toast"));
         } else if (key.equals(Preferences.AUTOMATIC_ACTION)) {
-            Util.writeDetaultStoreFile(this, sharedPreferences.getString(key, "prompt"));
+            Util.writeDetaultStoreFile(this);
         }
     }
 

src/com/noshufou/android/su/preferences/PreferencesFragment.java

@@ -246,7 +246,7 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
         } else if (key.equals(Preferences.PIN)) {
             setDepsNfc(sharedPreferences.getBoolean(Preferences.PIN, false));
         } else if (key.equals(Preferences.AUTOMATIC_ACTION)) {
-            Util.writeDetaultStoreFile(getActivity(), sharedPreferences.getString(key, "prompt"));
+            Util.writeDetaultStoreFile(getActivity());
         }
     }
 

src/com/noshufou/android/su/util/Util.java

@@ -57,6 +57,7 @@
 import com.noshufou.android.su.preferences.Preferences;
 import com.noshufou.android.su.preferences.PreferencesActivity;
 import com.noshufou.android.su.preferences.PreferencesActivityHC;
+import com.noshufou.android.su.provider.PermissionsProvider.Apps.AllowType;
 import com.noshufou.android.su.service.UpdaterService;
 
 public class Util {
@@ -810,28 +811,31 @@ public static boolean writeStoreFile(Context context, int uid, int execUid, Stri
         return true;
     }
 
-    public static boolean writeDetaultStoreFile(Context context, String action) {
-       File storedDir = new File(context.getFilesDir().getAbsolutePath() + File.separator + "stored");
-       storedDir.mkdirs();
-       File defFile = new File(storedDir.getAbsolutePath() + File.separator + "default");
-       try {
-           OutputStreamWriter out = new OutputStreamWriter(new FileOutputStream(defFile.getAbsolutePath()));
-           if (action.equals("allow")) {
-               out.write("1");
-           } else if (action.equals("deny")) {
-               out.write("0");
-           } else {
-               out.write("-1");
-           }
-           out.flush();
-           out.close();
-       } catch (FileNotFoundException e) {
-           Log.w(TAG, "Default file not written", e);
-           return false;
-       } catch (IOException e) {
-           Log.w(TAG, "Default file not written", e);
-           return false;
-       }
-       return true;
+    public static boolean writeDetaultStoreFile(Context context) {
+        File storedDir = new File(context.getFilesDir().getAbsolutePath() + File.separator + "stored");
+        storedDir.mkdirs();
+        File defFile = new File(storedDir.getAbsolutePath() + File.separator + "default");
+        SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
+        String action = prefs.getString(Preferences.AUTOMATIC_ACTION, "prompt");
+        try {
+            OutputStreamWriter out = new OutputStreamWriter(new FileOutputStream(defFile.getAbsolutePath()));
+            out.write("default\n");
+            if (action.equals("allow")) {
+                out.write("1");
+            } else if (action.equals("deny")) {
+                out.write("0");
+            } else {
+                out.write("-1");
+            }
+            out.flush();
+            out.close();
+        } catch (FileNotFoundException e) {
+            Log.w(TAG, "Default file not written", e);
+            return false;
+        } catch (IOException e) {
+            Log.w(TAG, "Default file not written", e);
+            return false;
+        }
+        return true;
     }
 }