codebase m

Author: Chrilleweb

src/core/determineComparisonFile.ts

@@ -3,14 +3,26 @@ import path from 'path';
 import { type ScanUsageOptions } from '../config/types.js';
 import { resolveFromCwd } from './helpers/resolveFromCwd.js';
 
+type ComparisonFile = {
+  path: string;
+  name: string;
+};
+
+const DEFAULT_ENV_FILES = [
+  '.env',
+  '.env.example',
+  '.env.local',
+  '.env.production',
+] as const;
+
 /**
  * Determines which file to use for comparison based on provided options
  * @param {ScanUsageOptions} opts - Scan configuration options
- * @returns {Object|null} - The comparison file information or undefined if not found
+ * @returns Comparison file info with absolute path and basename, or undefined if not found
  */
 export function determineComparisonFile(
   opts: ScanUsageOptions,
-): { path: string; name: string } | undefined {
+): ComparisonFile | undefined {
   // Priority: explicit flags first, then auto-discovery
 
   if (opts.examplePath) {
@@ -28,8 +40,7 @@ export function determineComparisonFile(
   }
 
   // Auto-discovery: look for common env files relative to cwd
-  const candidates = ['.env', '.env.example', '.env.local', '.env.production'];
-  for (const candidate of candidates) {
+  for (const candidate of DEFAULT_ENV_FILES) {
     const fullPath = path.resolve(opts.cwd, candidate);
     if (fs.existsSync(fullPath)) {
       return { path: fullPath, name: candidate };

src/services/duplicates.ts

@@ -1,4 +1,5 @@
 import fs from 'fs';
+import type { Duplicate } from '../config/types.js';
 
 /**
  * Scan a .env-like file for duplicate keys.
@@ -11,7 +12,7 @@ import fs from 'fs';
  */
 export function findDuplicateKeys(
   filePath: string,
-): Array<{ key: string; count: number }> {
+): Array<Duplicate> {
   if (!fs.existsSync(filePath)) return [];
 
   const raw = fs.readFileSync(filePath, 'utf8');
@@ -32,7 +33,7 @@ export function findDuplicateKeys(
     counts.set(key, (counts.get(key) ?? 0) + 1);
   }
 
-  const duplicates: Array<{ key: string; count: number }> = [];
+  const duplicates: Array<Duplicate> = [];
   for (const [key, count] of counts) {
     if (count > 1) duplicates.push({ key, count });
   }