Skip to content

Commit ca0f560

Browse files
authored
fix: catch unexpected error in event handlers (#672)
Closes #669 Follow-up upstream: puppeteer/puppeteer#14505
1 parent f6761e3 commit ca0f560

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

src/PageCollector.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,19 +83,27 @@ export class PageCollector<T> {
8383
}
8484

8585
#onTargetCreated = async (target: Target) => {
86-
const page = await target.page();
87-
if (!page) {
88-
return;
86+
try {
87+
const page = await target.page();
88+
if (!page) {
89+
return;
90+
}
91+
this.addPage(page);
92+
} catch (err) {
93+
logger('Error getting a page for a target onTargetCreated', err);
8994
}
90-
this.addPage(page);
9195
};
9296

9397
#onTargetDestroyed = async (target: Target) => {
94-
const page = await target.page();
95-
if (!page) {
96-
return;
98+
try {
99+
const page = await target.page();
100+
if (!page) {
101+
return;
102+
}
103+
this.cleanupPageDestroyed(page);
104+
} catch (err) {
105+
logger('Error getting a page for a target onTargetDestroyed', err);
97106
}
98-
this.cleanupPageDestroyed(page);
99107
};
100108

101109
public addPage(page: Page) {

0 commit comments

Comments
 (0)