HEI hangs on initial inventory open

[gberguy]

prism
Cleanroom-MMC-instance-0.5.9-alpha
HadEnoughItems_1.12.2-4.31.1
java 25
+388 mods

https://spark.lucko.me/Te8WK5j8B8

minimal issue, still worth it for the collapsible groups but..

slight hang ~2-3 seconds when opening inventory for the first time when joining a game.

I believe it's related to the group collapsing feature that was added recently.

likely hard to reproduce on a minimal mod loadout.
if collapsible groups is causing it.. you might need to populate the json with valid items... in my case i have 106 groups including the defaults.

reverting to HadEnoughItems_1.12.2-4.29.15 solves the issue.

[Rsslone]

HadEnoughItems_1.12.2-4.31.zip

Try this. The work needs to be done somewhere but I tried to see if I can prewarm the cache on join, so you might load in a tiny bit slower. Take a profile if you can to be sure. Also the anvils GUI will be slow again, its a different branch.

[gberguy]

no noticeable load time difference with that hei

hei still had an initial hang time, but maybe it was slightly faster? hard to tell.

https://spark.lucko.me/sOtT8O4yuV

i remembered something, and upon testing seems to be related..

in the HEI options, clicking on the manage groups button hangs for a long time, like 15-20 seconds or something, and getting progressively worse, it's quite cumbersome to work with. i ended up just adding stuff to the json manually because each time i wanted to add a new group, i would have to wait for it. also selecting items to add to the group each had a micro lag. like ~100ms so spam clicking didn't work.

deleting customCollapsibleGroups.json makes the lag when clicking on the manage groups button drop back down to 1-2 seconds.
and seems to have made HEI load quicker. like under a second, so basically unnoticeable when it's just the initial load.

the profile after i deleted customCollapsibleGroups.json incase you want it
https://spark.lucko.me/MArLafkYtc

i'll upload the json incase you want it too.

customCollapsibleGroups.json

[Rsslone]

Hm its still building the cache, but the early exits for prefix matching seemed to cut off almost a second off. I'll leave this here and see if there is anything else we can do, in terms of caching it.

#201 is still waiting to be approved and that should fix your performance woes with the manage groups, that should be addressed as soon as it is.

Appreciate the detailed report.

[Rsslone]

HadEnoughItems_1.12.2-4.31.zip

Give this one a quick try. Profile it like before if you could.

[gberguy]

https://spark.lucko.me/zire89YFkZ

seems faster