fix: the launchers memory should not effect the node memory (#1221)

### Motivation
The way our launcher works is that all jvm options of the launcher get
passed down to the started node instance. Therefore increasing the
memory in one of the start files would result in the memory increasing
for two different processes.
1. The launcher process it self start is started by the start file
2. The memory of the new node process started by the launcher

So that means that the memory consumption is doubled.

### Modification
Made sure to remove the -xmx and -xms options of the launcher before
passing the remaining options to the node and introduced a new option in
the launcher.cnl.
The new option `cloudnet.node.memory` is the new way to set the memory
of the node (in megabytes).

### Result
The memory is not occupied twice and the node memory is not dependant on
the launcher.

Author: 0utplay

.template/start.bat

@@ -6,5 +6,6 @@ IF %ERRORLEVEL% NEQ 0 (
   ECHO No valid java installation was found, please install java in order to run CloudNet
   EXIT /b 1
 ) ELSE (
-  java -Xms256M -Xmx256M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+:: DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
+  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
 )

.template/start.command

@@ -3,7 +3,8 @@ cd "$(dirname "$0")" || exit 1
 
 # check if java is installed
 if [ -x "$(command -v java)" ]; then
-  java -Xms256M -Xmx256M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+  # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
+  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
 else
   echo "No valid java installation was found, please install java in order to run CloudNet"
   exit 1

.template/start.sh

@@ -6,9 +6,11 @@ if [ -x "$(command -v java)" ]; then
   # if screen is present use that
   # this check is elevated as tmux is sometimes present by default
   if [ -x "$(command -v screen)" ]; then
-    screen -DRSq CloudNet java -Xms256M -Xmx256M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+    # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
+    screen -DRSq CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
   elif [ -x "$(command -v tmux)" ]; then
-    tmux new-session -As CloudNet java -Xms256M -Xmx256M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+    # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
+    tmux new-session -As CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
   else
     echo "No screen or tmux installation found, you need to install at least one of them to run CloudNet"
     exit 1

launcher/java17/src/main/java/eu/cloudnetservice/launcher/java17/ApplicationBootstrap.java

@@ -24,6 +24,7 @@
 import java.util.Arrays;
 import java.util.LinkedHashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeUnit;
@@ -51,7 +52,8 @@ public static void bootstrap(
     @NonNull Path applicationPath,
     @NonNull Set<Path> dependencies,
     @NonNull String[] processArguments,
-    int debuggerPort
+    int debuggerPort,
+    int nodeProcessMemory
   ) throws Exception {
     // resolve the current jar, we only append the launcher jar to it in case someone needs access to it
     var currentJar = Path.of(ApplicationBootstrap.class
@@ -66,8 +68,18 @@ public static void bootstrap(
     Set<String> arguments = new LinkedHashSet<>();
     arguments.add(resolveJavaExecutable());
 
+    // remove the xms and xmx options as we want to set them later on
+    var filteredInputArguments = RUNTIME_MX_BEAN.getInputArguments().stream().filter(inputArgument -> {
+      var lowerCaseInput = inputArgument.toLowerCase(Locale.ROOT);
+      return !lowerCaseInput.startsWith("-xmx") && !lowerCaseInput.startsWith("-xms");
+    }).toList();
+
     // add the arguments supplied to the current process
-    arguments.addAll(RUNTIME_MX_BEAN.getInputArguments());
+    arguments.addAll(filteredInputArguments);
+
+    // add the memory options for the node now
+    arguments.add("-Xmx" + nodeProcessMemory + 'M');
+    arguments.add("-Xms" + nodeProcessMemory + 'M');
 
     // add our default arguments & all system properties we might have set
     arguments.addAll(DEFAULT_PROCESS_ARGUMENTS);

launcher/java17/src/main/java/eu/cloudnetservice/launcher/java17/CloudNetLauncher.java

@@ -148,9 +148,12 @@ private void startApplication() throws Exception {
     // resolve the debugger port; use -1 if not given to disable the debugger
     int debugPort = CommandLineHelper.findProperty(this.commandLineArguments, "debug.port", "-1", Integer::parseInt);
 
+    // resolve the memory for the node process
+    int nodeMemory = CommandLineHelper.findProperty(this.commandLineArguments, "node.memory", "256", Integer::parseInt);
+
     // resolve all dependencies & start the application
     var dependencies = DependencyHelper.loadFromLibrariesFile(cloudNetJarPath);
-    ApplicationBootstrap.bootstrap(cloudNetJarPath, dependencies, this.originalArgs, debugPort);
+    ApplicationBootstrap.bootstrap(cloudNetJarPath, dependencies, this.originalArgs, debugPort, nodeMemory);
   }
 
   private void runCnlInterpreter() throws Exception {

launcher/java17/src/main/resources/launcher.cnl

@@ -46,6 +46,12 @@ var cloudnet.updateBranch beta
 # each level includes all messages for levels lower than itself (in the above list: left to right) too
 var cloudnet.logging.defaultlevel INFO
 
+# This value sets the memory settings of the JVM for the cloudnet node.
+# The value set here is to be specified in megabytes and describes -xmx as well as -xms.
+#
+# A change in the associated start files (e.g. start.sh) has no effect on the node and should therefore not be changed.
+var cloudnet.node.memory 256
+
 #
 # CloudNet runtime properties
 #