Update Task to Use Relative Working Path (#1844)

CETask now saves the relative working path instead of the absolute path to accommodate variations between users’ environments. The working directory field will remain empty by default, eliminating the need for user input. This change simplifies task configuration via the JSON file, as only the task name and command are now required.

Author: tom-ludwig

CodeEdit/Features/CEWorkSpaceSettings/CEWorkspaceSettings/Models/CETask.swift

@@ -30,9 +30,8 @@ class CETask: ObservableObject, Identifiable, Hashable, Codable {
         self.environmentVariables = environmentVariables
     }
 
-    init(target: String, workingDirectory: String) {
+    init(target: String) {
         self.target = target
-        self.workingDirectory = workingDirectory
     }
 
     var isInvalid: Bool {

CodeEdit/Features/CEWorkSpaceSettings/CEWorkspaceSettings/Views/AddCETaskView.swift

@@ -14,8 +14,8 @@ struct AddCETaskView: View {
     @EnvironmentObject var workspaceSettingsManager: CEWorkspaceSettings
     @StateObject var newTask: CETask
 
-    init(workingDirectory: String) {
-        self._newTask = StateObject(wrappedValue: CETask(target: "My Mac", workingDirectory: workingDirectory))
+    init() {
+        self._newTask = StateObject(wrappedValue: CETask(target: "My Mac"))
     }
     var body: some View {
         VStack(spacing: 0) {
@@ -47,5 +47,5 @@ struct AddCETaskView: View {
 }
 
 #Preview {
-    AddCETaskView(workingDirectory: "/User/")
+    AddCETaskView()
 }

CodeEdit/Features/CEWorkSpaceSettings/CEWorkspaceSettings/Views/CEWorkspaceSettingsView.swift

@@ -76,7 +76,7 @@ struct CEWorkspaceSettingsView: View {
                     selectedTaskIndex: selectedTaskIndex
                 )
             } else {
-                AddCETaskView(workingDirectory: workspace.fileURL?.relativePath ?? "")
+                AddCETaskView()
             }
         }
     }

CodeEdit/Features/CEWorkSpaceSettings/CEWorkspaceSettings/Views/EditCETaskView.swift

@@ -12,7 +12,7 @@ struct EditCETaskView: View {
     var dismiss
 
     @EnvironmentObject var workspaceSettingsManager: CEWorkspaceSettings
-    @EnvironmentObject var taskManger: TaskManager
+    @EnvironmentObject var taskManager: TaskManager
     @ObservedObject var task: CETask
 
     let selectedTaskIndex: Int
@@ -27,7 +27,7 @@ struct EditCETaskView: View {
                         $0.id == task.id
                     })
                     try? workspaceSettingsManager.savePreferences()
-                    taskManger.deleteTask(taskID: task.id)
+                    taskManager.deleteTask(taskID: task.id)
                     self.dismiss()
                 } label: {
                     Text("Delete")

CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift

@@ -133,7 +133,10 @@ final class WorkspaceDocument: NSDocument, ObservableObject, NSToolbarDelegate {
         self.commandsPaletteState = .init()
         self.workspaceSettingsManager = CEWorkspaceSettings(workspaceURL: url)
         if let workspaceSettingsManager {
-            self.taskManager = TaskManager(workspaceSettings: workspaceSettingsManager.settings)
+            self.taskManager = TaskManager(
+                workspaceSettings: workspaceSettingsManager.settings,
+                workspaceURL: url
+            )
         }
 
         editorManager?.restoreFromState(self)

CodeEdit/Features/Tasks/Models/CEActiveTask.swift

@@ -34,8 +34,16 @@ class CEActiveTask: ObservableObject, Identifiable, Hashable {
         }.store(in: &cancellables)
     }
 
-    func run() {
+    func run(workspaceURL: URL? = nil) {
         Task {
+            // Reconstruct the full command to ensure it executes in the correct directory.
+            // Because: CETask only contains information about the relative path.
+            let fullCommand: String
+            if let workspaceURL = workspaceURL {
+                fullCommand = "cd \(workspaceURL.relativePath) && \(task.fullCommand)"
+            } else {
+                fullCommand = task.fullCommand
+            }
             guard let process, let outputPipe else { return }
 
             await updateTaskStatus(to: .running)
@@ -61,7 +69,7 @@ class CEActiveTask: ObservableObject, Identifiable, Hashable {
             do {
                 try Shell.executeCommandWithShell(
                     process: process,
-                    command: self.task.fullCommand,
+                    command: fullCommand,
                     environmentVariables: self.task.environmentVariablesDictionary,
                     shell: Shell.zsh, // TODO: Let user decide which shell to use
                     outputPipe: outputPipe

CodeEdit/Features/Tasks/TaskManager.swift

@@ -16,9 +16,11 @@ class TaskManager: ObservableObject {
 
     @ObservedObject var workspaceSettings: CEWorkspaceSettingsData
 
+    private var workspaceURL: URL?
     private var settingsListener: AnyCancellable?
 
-    init(workspaceSettings: CEWorkspaceSettingsData) {
+    init(workspaceSettings: CEWorkspaceSettingsData, workspaceURL: URL? = nil) {
+        self.workspaceURL = workspaceURL
         self.workspaceSettings = workspaceSettings
 
         settingsListener = workspaceSettings.$tasks
@@ -75,10 +77,10 @@ class TaskManager: ObservableObject {
             while activeTask.status == .running {
                 await Task.yield()
             }
-            activeTask.run()
+            activeTask.run(workspaceURL: workspaceURL)
         } else {
             let runningTask = CEActiveTask(task: task)
-            runningTask.run()
+            runningTask.run(workspaceURL: workspaceURL)
             await MainActor.run {
                 activeTasks[task.id] = runningTask
             }

CodeEditTests/Features/Documents/DocumentsUnitTests.swift

@@ -22,7 +22,7 @@ final class DocumentsUnitTests: XCTestCase {
         super.setUp()
         hapticFeedbackPerformerMock = NSHapticFeedbackPerformerMock()
         navigatorViewModel = .init()
-        workspace.taskManager = TaskManager(workspaceSettings: .init())
+        workspace.taskManager = TaskManager(workspaceSettings: CEWorkspaceSettingsData())
         window = NSWindow()
         splitViewController = .init(
             workspace: workspace,