[Bug]: trigger trigger on interaction always acts like "one use" is checked

[meadowsys]

Before You Report

• My mods and Everest install are up to date.
• I have recreated the bug with a minimum number of mods installed.

What platform are you playing on?

macOS

Bug Description

A trigger trigger, when activation type is "On interaction" and "One Use" is unchecked, seems to still only allow interaction once per room load. The interact prompt does stay behind, just doesn't seem to do anything after it's been triggered until you reenter the room or die.

Steps to Reproduce

• Put a trigger to activate (ex. dialog trigger)
• create a trigger trigger (on interaction), point it at the dialog trigger, all other settings can be left at default
• go into the game, interact with the trigger
• observe it works
• interact again, observe it doesn't do anything

Log Output

doesn't seem to generate any logs on repeated presses

[meadowsys]

I had a poke around the code,

https://github.com/CommunalHelper/CrystallineHelper/blob/dev/Code/TriggerTrigger.cs#L376-L380

It seems to be this Activated field? as it is right now, it seems ActivateTriggers calls DeactivateTriggers, which sets Activated = false first, then ActivateTriggers itself continues and sets Activated = true. Then when TryActivate gets run again, Activated is stuck on true and TryActivate doesn't successfully update again.

the fix might (emphasis on might) be as simple as moving the line with Activate = true to the beginning of the file? I don't feel comfortable enough with the rest of the code to know if this subtle ordering change causes bugs though.