applied fixes

Author: AndreyAPopov

src/+otp/+kuramotosivashinsky/+presets/Canonical.m

@@ -32,7 +32,9 @@
 
             h = L/N;
 
-            x = h*(1:N).';
+            % exclude the left boundary point as it is identical to the
+            % right boundary point
+            x = linspace(h, L, N).';
 
             u0 = cos(x/16).*(1+sin(x/16));
 

src/+otp/+kuramotosivashinsky/KuramotoSivashinskyProblem.m

@@ -36,9 +36,9 @@ function onSettingsChanged(obj)
                 otp.Rhs.FieldNames.Jacobian, ...
                 @(t, u) otp.kuramotosivashinsky.jac(t,u, k, k2, k4), ...
                 otp.Rhs.FieldNames.JacobianVectorProduct, ...
-                @(t, u, v) otp.kuramotosivashinsky.jvp(t,u, k, k2, k4, v), ...
+                @(t, u, v) otp.kuramotosivashinsky.jvp(t, u, v, k, k2, k4), ...
                 otp.Rhs.FieldNames.JacobianAdjointVectorProduct, ...
-                @(t, u, v) otp.kuramotosivashinsky.javp(t,u, k, k2, k4, v));
+                @(t, u, v) otp.kuramotosivashinsky.javp(t, u, v, k, k2, k4));
 
         end
 
@@ -47,7 +47,9 @@ function validateNewState(obj, newTimeSpan, newY0, newParameters)
             validateNewState@otp.Problem(obj, ...
                 newTimeSpan, newY0, newParameters)
 
-            assert(mod(numel(newY0), 2) == 0);
+            if mod(numel(newY0), 2) ~= 0
+                error('The problem size has to be an even integer.');
+            end
 
             otp.utils.StructParser(newParameters) ...
                 .checkField('L', 'scalar', 'finite', 'positive');

src/+otp/+kuramotosivashinsky/javp.m

@@ -1,4 +1,4 @@
-function jv = javp(~, u, k, k2, k4, v)
+function jv = javp(~, u, v, k, k2, k4)
 
 jv = -k2.*v - k4.*v - fft(real(ifft(u)).*ifft(conj(k).*v));
 

src/+otp/+kuramotosivashinsky/jvp.m

@@ -1,4 +1,4 @@
-function jv = jvp(~, u, k, k2, k4, v)
+function jv = jvp(~, u, v, k, k2, k4)
 
 jv = -k2.*v - k4.*v - k.*fft(real(ifft(u)).*ifft(v));