Improve code coverage

Author: ajrgrubbs

eip712_structs/domain_separator.py

@@ -8,7 +8,7 @@ def make_domain(name=None, version=None, chainId=None, verifyingContract=None, s
     """
 
     if all(i is None for i in [name, version, chainId, verifyingContract, salt]):
-        raise ValueError('At least on argument must be given.')
+        raise ValueError('At least one argument must be given.')
 
     class EIP712Domain(eip712_structs.EIP712Struct):
         pass

tests/test_domain_separator.py

@@ -1,7 +1,10 @@
 import os
-from eip712_structs import make_domain
+
+import pytest
 from eth_utils.crypto import keccak
 
+from eip712_structs import make_domain
+
 
 def test_domain_sep_create():
     salt = os.urandom(32)
@@ -13,6 +16,9 @@ def test_domain_sep_create():
     expected_data = b''.join([keccak(text='name'), salt])
     assert domain_struct.encode_value() == expected_data
 
+    with pytest.raises(ValueError, match='At least one argument must be given'):
+        make_domain()
+
 
 def test_domain_sep_types():
     salt = os.urandom(32)

tests/test_encode_data.py

@@ -3,6 +3,7 @@
 import string
 
 from eth_utils.crypto import keccak
+import pytest
 
 from eip712_structs import Address, Array, Boolean, Bytes, Int, String, Uint, EIP712Struct, make_domain
 
@@ -158,3 +159,31 @@ class Foo(EIP712Struct):
     empty_string_hash = keccak(text='')
     assert encoded_val[0:32] == empty_string_hash
     assert encoded_val[32:] == bytes(32)
+
+
+def test_validation_errors():
+    bytes_type = Bytes(10)
+    int_type = Int(8)    # -128 <= i < 128
+    uint_type = Uint(8)  # 0 <= i < 256
+    bool_type = Boolean()
+
+    with pytest.raises(ValueError, match='bytes10 was given bytes with length 11'):
+        bytes_type.encode_value(os.urandom(11))
+
+    with pytest.raises(OverflowError, match='too big'):
+        int_type.encode_value(128)
+    with pytest.raises(OverflowError, match='too big'):
+        int_type.encode_value(-129)
+
+    with pytest.raises(OverflowError, match='too big'):
+        uint_type.encode_value(256)
+    assert uint_type.encode_value(0) == bytes(32)
+    with pytest.raises(OverflowError, match='negative int to unsigned'):
+        uint_type.encode_value(-1)
+
+    assert bool_type.encode_value(True) == bytes(31) + b'\x01'
+    assert bool_type.encode_value(False) == bytes(32)
+    with pytest.raises(ValueError, match='Must be True or False.'):
+        bool_type.encode_value(0)
+    with pytest.raises(ValueError, match='Must be True or False.'):
+        bool_type.encode_value(1)