Skip to content

Commit 2e5c6b0

Browse files
authored
Merge pull request #108 from NVIDIA/pr-2
Fix to problem where data on NFS mounts is deleted when mounting nest…
2 parents 8dc2ec8 + 7f22f62 commit 2e5c6b0

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

netshare/drivers/nfs.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,14 @@ func (n nfsDriver) Unmount(r volume.UnmountRequest) volume.Response {
119119

120120
n.mountm.DeleteIfNotManaged(resolvedName)
121121

122-
if err := os.RemoveAll(hostdir); err != nil {
123-
return volume.Response{Err: err.Error()}
124-
}
122+
// Check if directory is empty. This command will return "err" if empty
123+
if err := run(fmt.Sprintf("ls -1 %s | grep .", hostdir)); err == nil {
124+
log.Warnf("Directory %s not empty after unmount. Skipping RemoveAll call.", hostdir)
125+
} else {
126+
if err := os.RemoveAll(hostdir); err != nil {
127+
return volume.Response{Err: err.Error()}
128+
}
129+
}
125130

126131
return volume.Response{}
127132
}

0 commit comments

Comments
 (0)