Skip to content

Commit 9edb78e

Browse files
committed
Fixed imports and documentation.
1 parent 969f7e8 commit 9edb78e

File tree

3 files changed

+36
-10
lines changed

3 files changed

+36
-10
lines changed

README.md

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,34 @@ The method below will install the sysvinit and /etc/default options that can be
5656
```
5757
$ sudo docker-volume-netshare nfs
5858
```
59+
**2. Run the plugin - adding the correct DOCKER_API_VERSION
5960
If you are not using the latest stable version of docker engine please specify the version with flag.
6061
For example:
62+
To check docker API version:
63+
```
64+
docker version
65+
Client:
66+
Version: 17.12.0-ce
67+
API version: 1.35
68+
Go version: go1.9.2
69+
Git commit: c97c6d6
70+
Built: Wed Dec 27 20:11:19 2017
71+
OS/Arch: linux/amd64
72+
73+
Server:
74+
Engine:
75+
Version: 17.12.0-ce
76+
API version: 1.35 (minimum version 1.12)
77+
Go version: go1.9.2
78+
Git commit: c97c6d6
79+
Built: Wed Dec 27 20:09:53 2017
80+
OS/Arch: linux/amd64
81+
Experimental: false
82+
```
83+
Here the Docker API Version is 1.35. So you should start the plugin with the right version of Docker API.
84+
85+
Minimum supported version for the plugin is 1.12.
86+
6187
```
6288
$ sudo docker-volume-netshare nfs -a 1.35
6389
```
@@ -96,7 +122,7 @@ For example:
96122
**1. Run the plugin - can be added to systemd or run in the background**
97123

98124
```
99-
$ sudo docker-volume-netshare cifs --username user --password pass --domain domain --security security
125+
$ sudo docker-volume-netshare cifs --username user --password pass --domain domain --security security -a docker_api_version
100126
```
101127

102128
**2. Launch a container**
@@ -128,7 +154,7 @@ See example:
128154
**2. Run the plugin**
129155

130156
```
131-
$ sudo docker-volume-netshare cifs
157+
$ sudo docker-volume-netshare cifs -a docker_api_version
132158
```
133159

134160
**3. Launch a container**
@@ -146,7 +172,7 @@ options and other info can be eliminated when running a container.
146172
**1. Run the plugin - can be added to systemd or run in the background**
147173

148174
```
149-
$ sudo docker-volume-netshare cifs
175+
$ sudo docker-volume-netshare cifs -a docker_api_version
150176
```
151177

152178
**2. Create a Volume**

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package main
22

33
import (
4-
"github.com/jakirpatel/docker-volume-netshare/netshare"
4+
"github.com/ContainX/docker-volume-netshare/netshare"
55
)
66

77
var VERSION string = ""

netshare/netshare.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
package netshare
22

33
import (
4+
"context"
45
"fmt"
56
"os"
67
"path/filepath"
78
"strconv"
89
"syscall"
9-
"context"
1010

11-
"github.com/jakirpatel/docker-volume-netshare/netshare/drivers"
12-
log "github.com/sirupsen/logrus"
13-
"github.com/docker/go-plugins-helpers/volume"
14-
"github.com/spf13/cobra"
15-
"github.com/docker/docker/client"
11+
"github.com/ContainX/docker-volume-netshare/netshare/drivers"
1612
"github.com/docker/docker/api/types"
1713
"github.com/docker/docker/api/types/filters"
14+
"github.com/docker/docker/client"
15+
"github.com/docker/go-plugins-helpers/volume"
16+
log "github.com/sirupsen/logrus"
17+
"github.com/spf13/cobra"
1818
)
1919

2020
const (

0 commit comments

Comments
 (0)