latest ctrld crashed once in mikrotik container

[fhirrepo]

pulled latest docker container 1.4.9 today on mikrotik. crashed after few minutes. here is screenshot. have never had it crash in the past.

[cuonglm]

Thanks for reporting.

At first glance, sounds like it's not an issue specific to v1.4.9, since the piece of code that trigger the panic has not been changed for a while. Somehow, an empty IP was inserted to client info table, causing the panic.

We will fix this, in the meantime, could you please try other versions in the same environment and see if the panic still happens?

[cuonglm]

@fhirrepo I built a Docker image with a fix for this: https://hub.docker.com/layers/controldns/ctrld/dev-debug/images/sha256-f4e4d812100334fce2a811903588383ff66f15dfdb9761d89c833871b87dbdfa

Would you mind giving it a try?

Thank you.

[fhirrepo]

have applied it on my env now. not sure though if i can replicate the situation.will keep you posted if it happens again. it was happening when i was referring to upstream mikrotik main router for DNS(running docker ctrld) from my openwrt router(wan) dnsmasq (which was forwarding to mikrotik controld). issue was happening especially when i was changing network on openwrt end(like changing default lanip or introducing vlan etc). in those cases it was probably sending client requests to ctrld with null values...not sure just a guess