Skip to content

Commit 4a237ce

Browse files
Merge pull request #47 from Wojtach/fix/46-two-db-instances
Fix: Two db instances issue
2 parents 1f53693 + dfee26c commit 4a237ce

File tree

7 files changed

+17
-11
lines changed

7 files changed

+17
-11
lines changed

android/src/main/java/com/cblreactnative/CblReactnativeModule.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -745,13 +745,15 @@ class CblReactnativeModule(reactContext: ReactApplicationContext) :
745745
}
746746
try {
747747
val databaseConfig = DataAdapter.toDatabaseConfigJson(directory, encryptionKey)
748-
DatabaseManager.openDatabase(
748+
val databaseUniqueName = DatabaseManager.openDatabase(
749749
name,
750750
databaseConfig,
751751
context
752752
)
753753
context.runOnUiQueueThread {
754-
promise.resolve(null)
754+
val result = Arguments.createMap()
755+
result.putString("databaseUniqueName", databaseUniqueName)
756+
promise.resolve(result)
755757
}
756758
} catch (e: Throwable) {
757759
context.runOnUiQueueThread {

ios/CblReactnative.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -940,8 +940,10 @@ class CblReactnative: RCTEventEmitter {
940940
let hashConfig = AnyHashable(config)
941941
backgroundQueue.async {
942942
do {
943-
try DatabaseManager.shared.open(databaseName, databaseConfig: hashConfig as? [AnyHashable : Any])
944-
resolve(nil)
943+
let databaseUniqueName = try DatabaseManager.shared.open(databaseName, databaseConfig: hashConfig as? [AnyHashable : Any])
944+
945+
let resultDict: [String: Any] = ["databaseUniqueName": databaseUniqueName]
946+
resolve(resultDict)
945947
} catch let error as NSError {
946948
reject("DATABASE_ERROR", error.localizedDescription, nil)
947949
} catch {

ios/cbl-js-swift

src/CblReactNativeEngine.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,9 @@ export class CblReactNativeEngine implements ICoreEngine {
853853
});
854854
}
855855

856-
database_Open(args: DatabaseOpenArgs): Promise<void> {
856+
database_Open(
857+
args: DatabaseOpenArgs
858+
): Promise<{ databaseUniqueName: string }> {
857859
this.debugLog(
858860
`::DEBUG:: database_Open: ${args.name} ${args.config.directory} ${args.config.encryptionKey}`
859861
);
@@ -863,9 +865,9 @@ export class CblReactNativeEngine implements ICoreEngine {
863865
args.config.directory,
864866
args.config.encryptionKey
865867
).then(
866-
() => {
868+
(databaseUniqueName) => {
867869
this.debugLog(`::DEBUG:: database_Open completed`);
868-
resolve();
870+
resolve(databaseUniqueName);
869871
},
870872
// eslint-disable-next-line @typescript-eslint/no-explicit-any
871873
(error: any) => {

0 commit comments

Comments
 (0)