feat: Reverse admin check in globalSearch to retrieve public profiles for non-admin users

Author: fox3000foxy

dist/controllers/SearchController.js

@@ -53,7 +53,7 @@ let SearchController = class SearchController {
                 ? await this.userService.adminSearchUsers(query)
                 : await this.userService.searchUsersByUsername(query);
             const detailledUsers = await Promise.all(users.map(async (user) => {
-                const publicProfile = admin ?
+                const publicProfile = !admin ?
                     await this.userService.getUserWithPublicProfile(user.user_id) :
                     await this.userService.adminGetUserWithProfile(user.user_id);
                 return { id: user.user_id, ...publicProfile };

src/controllers/SearchController.ts

@@ -59,7 +59,7 @@ export class SearchController {
 
             const detailledUsers = await Promise.all(
                 users.map(async (user: PublicUser & UserExtensions) => {
-                    const publicProfile = admin ? 
+                    const publicProfile = !admin ? 
                         await this.userService.getUserWithPublicProfile(user.user_id):
                         await this.userService.adminGetUserWithProfile(user.user_id);
                     return { id: user.user_id, ...publicProfile };