Skip to content

Add getUnitAgl rpc and update streamunits with same#297

Draft
mobot-gh wants to merge 6 commits into
DCS-gRPC:mainfrom
mobot-gh:getUnitAgl
Draft

Add getUnitAgl rpc and update streamunits with same#297
mobot-gh wants to merge 6 commits into
DCS-gRPC:mainfrom
mobot-gh:getUnitAgl

Conversation

@mobot-gh
Copy link
Copy Markdown
Contributor

@mobot-gh mobot-gh commented May 4, 2026

No description provided.

Copy link
Copy Markdown
Collaborator

@YoloWingPixie YoloWingPixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Don't forget to update CHANGELOG Unreleased section

@dutchie031
Copy link
Copy Markdown
Collaborator

The code looks all good. No objections there.
I've left two comments, but as a bigger comment/discussion point is:
Do we want AGL as a more standardised transform/data point?

If we do:

  • It shouldn't have it's own getUnitAGL (as it's in the getUnit as well)
  • It should be part of the getTransform as it's then part of standardised 3d positioning information.

If we don't:

  • It shouldn't be part of the stream data (if not standardised the client needs to request on demand)

Just thought it might be worth a thought

@dutchie031 dutchie031 closed this May 18, 2026
@dutchie031 dutchie031 reopened this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants