Add Test for Ayrton Domino S Binary

patrick-dmxc · patrick-dmxc · commit 670b86655e45 · 2025-07-05T03:09:47.000+02:00
Fix Tests
diff --git a/ArtNetSharp/Communication/AbstractInstance.cs b/ArtNetSharp/Communication/AbstractInstance.cs
@@ -732,6 +732,7 @@ public async Task SendArtRDM(RDMMessage rdmMessage)
             {
                 var ports = RemoteClientsPorts.Where(port => port.KnownResponderRDMUIDs.Count != 0).Where(port => port.OutputPortAddress.HasValue && port.KnownResponderRDMUIDs.Any(bag => bag.Uid == rdmMessage.DestUID)).ToList();
                 List<Task> tasks = new List<Task>();
+                List<Tuple<IPv4Address, PortAddress>> tuples = new List<Tuple<IPv4Address, PortAddress>>();
                 foreach (var port in ports)
                 {
                     PortAddress pa = default;
@@ -740,6 +741,9 @@ public async Task SendArtRDM(RDMMessage rdmMessage)
                     else if (rdmMessage.Command.HasFlag(ERDM_Command.RESPONSE) && port.InputPortAddress.HasValue)
                         pa = port.InputPortAddress.Value;
                     //Todo Buffer per IP address to prevent Hardware from overflow
+                    if (tuples.Any(t => t.Item2 == pa && t.Item1 == port.IpAddress))// skip multiple send the same Package to the same IP
+                        continue;
+                    tuples.Add(new Tuple<IPv4Address, PortAddress>(port.IpAddress, pa));
                     ArtRDM artRDM = new ArtRDM(pa, rdmMessage);
                     tasks.Add(Task.Run(async () => await TrySendPacket(artRDM, port.IpAddress)));
                 }
diff --git a/ArtNetTests/Binary Tests/ArtPollReplyBinaryTests.cs b/ArtNetTests/Binary Tests/ArtPollReplyBinaryTests.cs
@@ -9,7 +9,7 @@ namespace ArtNetTests.Binary_Tests
     [TestFixtureSource(typeof(AbstractArtPollReplyBinaryTestSubject), nameof(AbstractArtPollReplyBinaryTestSubject.TestSubjects))]
     public class ArtPollReplyBinaryTests
     {
-        private static readonly ILogger Logger = ApplicationLogging.CreateLogger<ArtPollReplyBinaryTests>();
+        private static readonly ILogger Logger = ArtNetSharp.Logging.CreateLogger<ArtPollReplyBinaryTests>();
         private readonly AbstractArtPollReplyBinaryTestSubject testSubject;
 
         public ArtPollReplyBinaryTests(AbstractArtPollReplyBinaryTestSubject _TestSubject)
diff --git a/ArtNetTests/Binary Tests/Ayrton/Ayrton_Domino_S_2_2_4.cs b/ArtNetTests/Binary Tests/Ayrton/Ayrton_Domino_S_2_2_4.cs
@@ -0,0 +1,62 @@
+﻿using ArtNetSharp;
+
+namespace ArtNetTests.Binary_Tests.Ayrton
+{
+    internal class Ayrton_Domino_S_2_2_4 : AbstractArtPollReplyBinaryTestSubject
+    {
+        private static readonly byte[] DATA = [
+            0x41, 0x72, 0x74, 0x2d, 0x4e, 0x65, 0x74, 0x00,
+            0x00, 0x21, 0x02, 0x03, 0x04, 0x05, 0x36, 0x19,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x12,
+            0x79, 0x41, 0x44, 0x4f, 0x4d, 0x49, 0x4e, 0x4f,
+            0x20, 0x53, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x41, 0x59, 0x52, 0x54,
+            0x4f, 0x4e, 0x20, 0x44, 0x4f, 0x4d, 0x49, 0x4e,
+            0x4f, 0x20, 0x53, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x80, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x06, 0x5f, 0x00, 0x01, 0x81, 0x02,
+            0x03, 0x04, 0x05, 0x01, 0x00, 0x04, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+            0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 ];
+
+        private static readonly PortTestSubject[] PORTS =
+        [
+            new PortTestSubject(EPortType.OutputFromArtNet,(Address)0,(Address)0)
+        ];
+        public Ayrton_Domino_S_2_2_4() : base(
+            "Ayrton Dimino S (FW 2.2.4)",
+            DATA,
+            0,
+            "DOMINO S",
+            "AYRTON DOMINO S",
+            new MACAddress("00:06:5f:00:01:81"),
+            new IPv4Address("2.3.4.5"),
+            new IPv4Address("2.3.4.5"),
+            0x00ff,
+            0x4179,
+            EStCodes.StNode,
+            PORTS,
+            false,
+            majorVersion: 0,
+            minorVersion: 0)
+        {
+        }
+    }
+}
diff --git a/ArtNetTests/Binary Tests/Robe/Robe_Esprite_3_9.cs b/ArtNetTests/Binary Tests/Robe/Robe_Esprite_3_9.cs
@@ -1,6 +1,6 @@
 ﻿using ArtNetSharp;
 
-namespace ArtNetTests.Binary_Tests.Astera
+namespace ArtNetTests.Binary_Tests.Robe
 {
     internal class Robe_Esprite_3_9 : AbstractArtPollReplyBinaryTestSubject
     {
diff --git a/ArtNetTests/Binary Tests/Robe/Robe_Tetra2_3_5.cs b/ArtNetTests/Binary Tests/Robe/Robe_Tetra2_3_5.cs
@@ -1,6 +1,6 @@
 ﻿using ArtNetSharp;
 
-namespace ArtNetTests.Binary_Tests.Astera
+namespace ArtNetTests.Binary_Tests.Robe
 {
     internal class Robe_Tetra2_3_5 : AbstractArtPollReplyBinaryTestSubject
     {
diff --git a/ArtNetTests/LoggingTests.cs b/ArtNetTests/LoggingTests.cs
@@ -15,7 +15,7 @@ public void TestLogging()
             logger.LogWarning(new Exception("Test"));
             logger.LogError(new Exception("Test"));
             logger.LogCritical(new Exception("Test"));
-            logger = ApplicationLogging.CreateLogger<LoggingTests>();
+            logger = ArtNetSharp.Logging.CreateLogger<LoggingTests>();
             logger.LogTrace(new Exception("Test"));
             logger.LogDebug(new Exception("Test"));
             logger.LogInformation(new Exception("Test"));
diff --git a/ArtNetTests/TestOS.cs b/ArtNetTests/TestOS.cs
@@ -10,7 +10,7 @@ namespace ArtNetTests
     [Order(30)]
     public class TestOS
     {
-        private static readonly ILogger Logger = ApplicationLogging.CreateLogger<TestOS>();
+        private static readonly ILogger Logger = ArtNetSharp.Logging.CreateLogger<TestOS>();
         private NodeInstance nodeInstance;
         private ControllerInstance controllerInstance;
         private const byte ports = 2;

Original file line number	Diff line number	Diff line change
`@@ -732,6 +732,7 @@ public async Task SendArtRDM(RDMMessage rdmMessage)`
`732`	`732`	`{`
`733`	`733`	`var ports = RemoteClientsPorts.Where(port => port.KnownResponderRDMUIDs.Count != 0).Where(port => port.OutputPortAddress.HasValue && port.KnownResponderRDMUIDs.Any(bag => bag.Uid == rdmMessage.DestUID)).ToList();`
`734`	`734`	`List<Task> tasks = new List<Task>();`
	`735`	`+ List<Tuple<IPv4Address, PortAddress>> tuples = new List<Tuple<IPv4Address, PortAddress>>();`
`735`	`736`	`foreach (var port in ports)`
`736`	`737`	`{`
`737`	`738`	`PortAddress pa = default;`
`@@ -740,6 +741,9 @@ public async Task SendArtRDM(RDMMessage rdmMessage)`
`740`	`741`	`else if (rdmMessage.Command.HasFlag(ERDM_Command.RESPONSE) && port.InputPortAddress.HasValue)`
`741`	`742`	`pa = port.InputPortAddress.Value;`
`742`	`743`	`//Todo Buffer per IP address to prevent Hardware from overflow`
	`744`	`+ if (tuples.Any(t => t.Item2 == pa && t.Item1 == port.IpAddress))// skip multiple send the same Package to the same IP`
	`745`	`+ continue;`
	`746`	`+ tuples.Add(new Tuple<IPv4Address, PortAddress>(port.IpAddress, pa));`
`743`	`747`	`ArtRDM artRDM = new ArtRDM(pa, rdmMessage);`
`744`	`748`	`tasks.Add(Task.Run(async () => await TrySendPacket(artRDM, port.IpAddress)));`
`745`	`749`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace ArtNetTests.Binary_Tests`
`9`	`9`	`[TestFixtureSource(typeof(AbstractArtPollReplyBinaryTestSubject), nameof(AbstractArtPollReplyBinaryTestSubject.TestSubjects))]`
`10`	`10`	`public class ArtPollReplyBinaryTests`
`11`	`11`	`{`
`12`		`- private static readonly ILogger Logger = ApplicationLogging.CreateLogger<ArtPollReplyBinaryTests>();`
	`12`	`+ private static readonly ILogger Logger = ArtNetSharp.Logging.CreateLogger<ArtPollReplyBinaryTests>();`
`13`	`13`	`private readonly AbstractArtPollReplyBinaryTestSubject testSubject;`
`14`	`14`
`15`	`15`	`public ArtPollReplyBinaryTests(AbstractArtPollReplyBinaryTestSubject _TestSubject)`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`using ArtNetSharp;`
`2`	`2`
`3`		`-namespace ArtNetTests.Binary_Tests.Astera`
	`3`	`+namespace ArtNetTests.Binary_Tests.Robe`
`4`	`4`	`{`
`5`	`5`	`internal class Robe_Esprite_3_9 : AbstractArtPollReplyBinaryTestSubject`
`6`	`6`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace ArtNetTests`
`10`	`10`	`[Order(30)]`
`11`	`11`	`public class TestOS`
`12`	`12`	`{`
`13`		`- private static readonly ILogger Logger = ApplicationLogging.CreateLogger<TestOS>();`
	`13`	`+ private static readonly ILogger Logger = ArtNetSharp.Logging.CreateLogger<TestOS>();`
`14`	`14`	`private NodeInstance nodeInstance;`
`15`	`15`	`private ControllerInstance controllerInstance;`
`16`	`16`	`private const byte ports = 2;`