Skip to content

Commit 4cb34f5

Browse files
committed
cmake: add comments for future self to improve the CMake code
1 parent cbe119e commit 4cb34f5

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

CMakeLists.txt

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@ if (NOT CMAKE_OSX_ARCHITECTURES)
6767
set(CMAKE_OSX_ARCHITECTURES x86_64)
6868
endif()
6969

70+
# FIXME: this reports an unused architecture if only vms are built.
71+
# We may not be able to avoid this for now without doing a huge rewrite
72+
# of this file.
73+
# FIXME: this reports an unused compiler if only vms are built.
74+
# We cannot avoid this for now without doing a huge rewrite of this files
75+
# since we also set useless flags using informations provided by this.
76+
if (NOT (BUILD_CLIENT OR BUILD_TTY_CLIENT OR BUILD_SERVER OR BUILD_DUMMY_APP))
77+
message(NOTICE "You can safely ignore the following reported architecture, it is not used.")
78+
message(NOTICE "You can safely ignore the following reported compilers, they are unused.")
79+
endif()
7080
include(DaemonPlatform)
7181

7282
if (Daemon_OUT)
@@ -288,8 +298,17 @@ endif()
288298
# Compile and link flags
289299
################################################################################
290300

301+
# FIXME: This sets unused flags for an unused compiler if only nacl vms
302+
# are built and we are not yet running the chainloaded build. We cannot
303+
# avoid this for now or we would have to do a large rewrite of that file.
304+
# FIXME: This defines the try_flag function that is used in
305+
# Unvanquished CMakeLists.txt even if the engine is not built,
306+
# meaning we have to detect useless engine compiler to set
307+
# useless engine flags when only building vms.
291308
include(DaemonFlags)
292309

310+
# FIXME: Once engine flags would be only set when building the engine
311+
# this would be likely unused by vms as they are built by DaemonGame.
293312
# Warning options (for Daemon only)
294313
# Note the different scopes used for warning options:
295314
# * set_c_cxx_flag(xxx) or try_c_cxx_flag(xxx) sets it for all code including dependencies

0 commit comments

Comments
 (0)