Fix potential index out of bounds in Material.cpp

j-mattsson · slipher · commit 7406196da3c1 · 2025-01-03T17:58:47.000-03:00
diff --git a/src/engine/renderer/Material.cpp b/src/engine/renderer/Material.cpp
@@ -1950,7 +1950,7 @@ void MaterialSystem::AddDrawCommand( const uint32_t materialID, const uint32_t m
 }
 
 void MaterialSystem::AddTexture( Texture* texture ) {
-	if ( cmd.textureCount > MAX_DRAWCOMMAND_TEXTURES ) {
+	if ( cmd.textureCount >= MAX_DRAWCOMMAND_TEXTURES ) {
 		Sys::Drop( "Exceeded max DrawCommand textures" );
 	}
 	cmd.textures[cmd.textureCount] = texture;

Original file line number	Diff line number	Diff line change
`@@ -1950,7 +1950,7 @@ void MaterialSystem::AddDrawCommand( const uint32_t materialID, const uint32_t m`
`1950`	`1950`	`}`
`1951`	`1951`
`1952`	`1952`	`void MaterialSystem::AddTexture( Texture* texture ) {`
`1953`		`- if ( cmd.textureCount > MAX_DRAWCOMMAND_TEXTURES ) {`
	`1953`	`+ if ( cmd.textureCount >= MAX_DRAWCOMMAND_TEXTURES ) {`
`1954`	`1954`	`Sys::Drop( "Exceeded max DrawCommand textures" );`
`1955`	`1955`	`}`
`1956`	`1956`	`cmd.textures[cmd.textureCount] = texture;`