Skip to content

Commit cea890f

Browse files
committed
Switch bloom cvars to new-style
1 parent 29c5ad6 commit cea890f

File tree

4 files changed

+13
-15
lines changed

4 files changed

+13
-15
lines changed

src/engine/renderer/tr_backend.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3104,15 +3104,15 @@ void RB_RenderBloom()
31043104

31053105
gl_blurXShader->BindProgram( 0 );
31063106

3107-
gl_blurXShader->SetUniform_DeformMagnitude( r_bloomBlur->value );
3107+
gl_blurXShader->SetUniform_DeformMagnitude( r_bloomBlur.Get() );
31083108
gl_blurXShader->SetUniform_TexScale( texScale );
31093109

31103110
gl_blurXShader->SetUniform_ColorMapBindless(
31113111
GL_BindToTMU( 0, tr.contrastRenderFBOImage )
31123112
);
31133113

31143114
int flip = 0;
3115-
for ( int i = 0; i < r_bloomPasses->integer; i++ ) {
3115+
for ( int i = 0; i < r_bloomPasses.Get(); i++ ) {
31163116
R_BindFBO( tr.bloomRenderFBO[flip] );
31173117
glClear( GL_COLOR_BUFFER_BIT );
31183118
Tess_InstantQuad( *gl_blurXShader,
@@ -3127,14 +3127,14 @@ void RB_RenderBloom()
31273127

31283128
gl_blurYShader->BindProgram( 0 );
31293129

3130-
gl_blurYShader->SetUniform_DeformMagnitude( r_bloomBlur->value );
3130+
gl_blurYShader->SetUniform_DeformMagnitude( r_bloomBlur.Get() );
31313131
gl_blurYShader->SetUniform_TexScale( texScale );
31323132

31333133
gl_blurYShader->SetUniform_ColorMapBindless(
31343134
GL_BindToTMU( 0, tr.bloomRenderFBOImage[flip ^ 1] )
31353135
);
31363136

3137-
for ( int i = 0; i < r_bloomPasses->integer; i++ ) {
3137+
for ( int i = 0; i < r_bloomPasses.Get(); i++ ) {
31383138
R_BindFBO( tr.bloomRenderFBO[flip] );
31393139
glClear( GL_COLOR_BUFFER_BIT );
31403140
Tess_InstantQuad( *gl_blurYShader,

src/engine/renderer/tr_init.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -276,10 +276,10 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
276276
cvar_t *r_vboVertexSkinning;
277277

278278
cvar_t *r_mergeLeafSurfaces;
279-
280-
cvar_t *r_bloom;
281-
cvar_t *r_bloomBlur;
282-
cvar_t *r_bloomPasses;
279+
280+
Cvar::Cvar<bool> r_bloom( "r_bloom", "Use bloom", Cvar::ARCHIVE, false );
281+
Cvar::Cvar<float> r_bloomBlur( "r_bloomBlur", "Bloom strength", Cvar::NONE, 1.0 );
282+
Cvar::Cvar<int> r_bloomPasses( "r_bloomPasses", "Amount of bloom passes in each direction", Cvar::NONE, 2 );
283283
cvar_t *r_FXAA;
284284
cvar_t *r_ssao;
285285

@@ -1198,9 +1198,7 @@ ScreenshotCmd screenshotPNGRegistration("screenshotPNG", ssFormat_t::SSF_PNG, "p
11981198

11991199
r_printShaders = Cvar_Get( "r_printShaders", "0", 0 );
12001200

1201-
r_bloom = Cvar_Get( "r_bloom", "0", CVAR_LATCH | CVAR_ARCHIVE );
1202-
r_bloomBlur = Cvar_Get( "r_bloomBlur", "1.0", CVAR_CHEAT );
1203-
r_bloomPasses = Cvar_Get( "r_bloomPasses", "2", CVAR_CHEAT );
1201+
Cvar::Latch( r_bloom );
12041202
r_FXAA = Cvar_Get( "r_FXAA", "0", CVAR_LATCH | CVAR_ARCHIVE );
12051203
r_ssao = Cvar_Get( "r_ssao", "0", CVAR_LATCH | CVAR_ARCHIVE );
12061204

src/engine/renderer/tr_local.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3065,9 +3065,9 @@ enum class shaderProfilerRenderSubGroupsMode {
30653065

30663066
extern cvar_t *r_mergeLeafSurfaces;
30673067

3068-
extern cvar_t *r_bloom;
3069-
extern cvar_t *r_bloomBlur;
3070-
extern cvar_t *r_bloomPasses;
3068+
extern Cvar::Cvar<bool> r_bloom;
3069+
extern Cvar::Cvar<float> r_bloomBlur;
3070+
extern Cvar::Cvar<int> r_bloomPasses;
30713071
extern cvar_t *r_FXAA;
30723072
extern cvar_t *r_ssao;
30733073

src/engine/renderer/tr_shade.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ static void EnableAvailableFeatures()
142142
glConfig2.specularMapping = glConfig2.deluxeMapping && glConfig2.specularMapping;
143143
glConfig2.physicalMapping = glConfig2.deluxeMapping && glConfig2.physicalMapping;
144144

145-
glConfig2.bloom = r_bloom->integer;
145+
glConfig2.bloom = r_bloom.Get();
146146

147147
/* Motion blur is enabled by cg_motionblur which is a client cvar so we have to build it in all cases,
148148
unless unsupported by the hardware which is the only condition when the engine knows it is not used. */

0 commit comments

Comments
 (0)